Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment formatting & empty newline removal. #38796

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@NonCreature0714
Copy link

NonCreature0714 commented Feb 26, 2019

Removed a newline between two closing braces which didn't seem to conform with the general style. Also removed an empty newline between a closing brace and return statement. Reformated some comments so they don't run for so long on a single line. Added one period. Took away one comma.

- What I did
Removed two extraneous newlines which didn't seem to conform to general style. Also rearranged long comments to fit into a smaller line width. Added one period. Took away one comma.

- How I did it
Edited on Github editor.

- How to verify it
I made no changes to the code itself, so it will work the same as before.

- Description for the changelog

Grammar, readability, and code conformity.

- A picture of a cute animal (not mandatory but encouraged)

Comment formatting & empty newline removal.
Removed a newline between two closing braces which didn't seem to conform with the general style. Also removed an empty newline between a closing brace and return statement. Reformated some comments so they don't run for so long on a single line.
@GordonTheTurtle

This comment has been minimized.

Copy link

GordonTheTurtle commented Feb 26, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:NonCreature0714/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@NonCreature0714

This comment has been minimized.

Copy link
Author

NonCreature0714 commented Mar 1, 2019

I'll make the correction soon, I've just been busy.

@thaJeztah

This comment has been minimized.

Copy link
Member

thaJeztah commented Mar 21, 2019

were you still working on this?

@NonCreature0714

This comment has been minimized.

Copy link
Author

NonCreature0714 commented Mar 21, 2019

@thaJeztah

This comment has been minimized.

Copy link
Member

thaJeztah commented Apr 1, 2019

closing this for now, but let me know if you have time to work on this again

@thaJeztah thaJeztah closed this Apr 1, 2019

@NonCreature0714

This comment has been minimized.

Copy link
Author

NonCreature0714 commented Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.