Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #38837

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Three7Six
Copy link

Three7Six commented Mar 7, 2019

closes #38836

- What I did
Grammatical changes to README
Remove ambiguous pronouns. Separate long and confusing sentences into multiple sentences. Removed redundant words (Building blocks + in conjunction)
- How I did it
N/A
- How to verify it
N/A
- Description for the changelog

Grammatical changes to README

- A picture of a cute animal (not mandatory but encouraged)

Update README.md
Update README for better readability.

Remove ambiguous pronouns. Separate long and confusing sentences into multiple sentences. Removed redundant words (Building blocks + in conjunction)
@GordonTheTurtle

This comment has been minimized.

Copy link

GordonTheTurtle commented Mar 7, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:Three7Six/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah

This comment has been minimized.

Copy link
Member

thaJeztah commented Mar 16, 2019

@Three7Six could you amend your commit and add a DCO sign-off (you can use the instructions that @GordonTheTurtle (our bot) left, but let me know if you need help doing so

@thaJeztah

This comment has been minimized.

Copy link
Member

thaJeztah commented Apr 1, 2019

Closing, as there's no dco sign-off

@thaJeztah thaJeztah closed this Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.