Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the license #38867

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@markelog
Copy link

markelog commented Mar 13, 2019

According to https://apache.org/licenses/LICENSE-2.0#apply, this is how the apache license should be phraised. Also removed the current year, since it's not needed and relieves you from updating it every year

@GordonTheTurtle

This comment has been minimized.

Copy link

GordonTheTurtle commented Mar 13, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:markelog/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Correct the license
According to https://apache.org/licenses/LICENSE-2.0#apply,
this is how the apache license should be phraised.

Also removed the current year, since it's not needed and
relieves you from updating it every year

Signed-off-by: Oleg Gaidarenko <markelog@gmail.com>

@markelog markelog force-pushed the markelog:patch-1 branch from e98907a to 042411d Mar 13, 2019

@GordonTheTurtle GordonTheTurtle removed the dco/no label Mar 13, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 13, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@46036c2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #38867   +/-   ##
=========================================
  Coverage          ?   36.43%           
=========================================
  Files             ?      613           
  Lines             ?    45830           
  Branches          ?        0           
=========================================
  Hits              ?    16697           
  Misses            ?    26849           
  Partials          ?     2284
@thaJeztah
Copy link
Member

thaJeztah left a comment

Hm, no, I don't think this is correct (although the current LICENSE also isn't correct); the correct way is to;

  • update the LICENSE file to be an unmodified version of the license (so without copyright information in the license itself; that section is only an example
  • add a license header to all files

There are different opinions on the year ranges (and that's still a bit of a grey area); I think the general concensus is that (if each file has a year mentioned) to at least have the year in which a file was added, and if significant changes are made, to make it a "range".

The containerd project made similar changes a while back; containerd/containerd#2108, and perhaps we should make the same modifications in this repository; they're using a tool to automatically add the headers to all files (and a check in CI to verify).

@markelog

This comment has been minimized.

Copy link
Author

markelog commented Mar 20, 2019

Wowzies, okay! Will update the PR

@markelog markelog referenced this pull request Mar 20, 2019

Open

Update LICENSE #43

@thaJeztah

This comment has been minimized.

Copy link
Member

thaJeztah commented Mar 20, 2019

Let me know if you need help (I started looking into that tool they used in containerd, but never had time to finish 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.