Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in memory libcontainer containers map #38914

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@crosbymichael
Copy link
Member

commented Mar 20, 2019

Signed-off-by: Michael Crosby crosbymichael@gmail.com

@crosbymichael crosbymichael requested a review from cpuguy83 as a code owner Mar 20, 2019

@crosbymichael crosbymichael force-pushed the crosbymichael:opts branch 8 times, most recently from 6d7a56b to 9193a40 Mar 20, 2019

Show resolved Hide resolved libcontainerd/remote/client.go Outdated
return -1, errors.WithStack(errdefs.Conflict(errors.New("container already started")))
ctr, err := c.getContainer(ctx, id)
if err != nil {
return -1, wrapError(err)

This comment has been minimized.

Copy link
@thaJeztah

thaJeztah Mar 21, 2019

Member

I see wrapError only handles "notFound" errors; is it possible other type of errors are returned?

This comment has been minimized.

Copy link
@crosbymichael

crosbymichael Mar 21, 2019

Author Member

not in this pr

This comment has been minimized.

Copy link
@thaJeztah

thaJeztah Mar 21, 2019

Member

Was asking because I saw before this change some other type of errors were returned; just to be sure we don't regress.

I'm ok with adding more types in a follow up

@crosbymichael crosbymichael force-pushed the crosbymichael:opts branch from 9193a40 to 24dc193 Mar 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@6daf5ab). Click here to learn what that means.
The diff coverage is 62.5%.

@@            Coverage Diff            @@
##             master   #38914   +/-   ##
=========================================
  Coverage          ?   36.91%           
=========================================
  Files             ?      614           
  Lines             ?    45373           
  Branches          ?        0           
=========================================
  Hits              ?    16748           
  Misses            ?    26332           
  Partials          ?     2293
Remove in memory libcontainer containers map
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.