gitutils: add validation for ref (CVE-2019-13139) #38944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 723b107ca4fba14580a6cd971e63d8af2e7d2bbe) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
This was referenced Mar 26, 2019
justincormack
approved these changes
Mar 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #38944 +/- ##
=========================================
Coverage ? 36.9%
=========================================
Files ? 614
Lines ? 45404
Branches ? 0
=========================================
Hits ? 16757
Misses ? 26357
Partials ? 2290 |
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Mar 27, 2019
relevant changes; - moby/moby#38006 / docker-archive/engine#114 client: use io.LimitedReader for reading HTTP error - moby/moby#38634 / docker-archive/engine#167 pkg/archive:CopyTo(): fix for long dest filename - fixes docker/for-linux#484 for 18.09 - moby/moby#38944 / docker-archive/engine#183 gitutils: add validation for ref - moby/moby#37780 / docker-archive/engine#55 pkg/progress: work around closing closed channel panic - addresses moby/moby#/37735 pkg/progress: panic due to race on shutdown Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Mar 27, 2019
relevant changes; - moby/moby#38006 / docker-archive/engine#114 client: use io.LimitedReader for reading HTTP error - moby/moby#38634 / docker-archive/engine#167 pkg/archive:CopyTo(): fix for long dest filename - fixes docker/for-linux#484 for 18.09 - moby/moby#38944 / docker-archive/engine#183 gitutils: add validation for ref - moby/moby#37780 / docker-archive/engine#55 pkg/progress: work around closing closed channel panic - addresses moby/moby#/37735 pkg/progress: panic due to race on shutdown Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 010c234a0d5a03d450ebec60be37dd9f279feeca Component: cli
thaJeztah
changed the title
|
For reference I requested a CVE and CVE-2019-13139 has been reserved for this issue. |
|
@staaldraad thanks! I got notified of the CVE, so updated the titles of all the related PR's to include it 👍 We should probably update the release notes as well; https://github.com/docker/docker.github.io/blob/master/engine/release-notes.md#18094 Let me know if you're interested in opening a pull request in that repository, or if you want me to do so |
|
Thanks @thaJeztah 🎉 I've opened a PR -- wanted to tag you in as reviewer but it seems like labels and reviewers aren't available to non-project members |
This was referenced Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a fix that @tonistiigi created, this PR adds validation for git ref so it can't be misinterpreted as a flag.
fetch --is a cleaner option but as it is theoretically possible to also hit it in checkout there's a custom validation as well.Thanks to @staaldraad for pointing this issue out originally.
cc @justincormack