Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: buildkit now honors daemon's DNS config #39329

Merged
merged 1 commit into from Jul 16, 2019
Merged

build: buildkit now honors daemon's DNS config #39329

merged 1 commit into from Jul 16, 2019

Conversation

tiborvass
Copy link
Contributor

@tiborvass tiborvass commented Jun 6, 2019 •
edited

Signed-off-by: Tibor Vass tibor@docker.com

Depends on moby/buildkit#1060

@tiborvass tiborvass force-pushed the buildkit-honor-daemon-dnsconfig branch 3 times, most recently from d0c0d04 to e43eddc Compare June 6, 2019 02:57
@thaJeztah
Copy link
Member

Build is failing on Windows;

02:59:01 # github.com/docker/docker/vendor/github.com/moby/buildkit/executor/oci
02:59:01 ..\..\vendor\github.com\moby\buildkit\executor\oci\mounts.go:96:34: undefined: ProcessMode
02:59:01 ..\..\vendor\github.com\moby\buildkit\executor\oci\mounts.go:99:8: undefined: ProcessSandbox
02:59:01 ..\..\vendor\github.com\moby\buildkit\executor\oci\user.go:23:21: undefined: user.GetPasswdPath
02:59:01 ..\..\vendor\github.com\moby\buildkit\executor\oci\user.go:27:20: undefined: user.GetGroupPath

@tiborvass tiborvass force-pushed the buildkit-honor-daemon-dnsconfig branch from e43eddc to ea8efb7 Compare June 17, 2019 23:44
@codecov
Copy link

codecov bot commented Jun 17, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@f550cb5). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #39329   +/-   ##
=========================================
  Coverage          ?   37.31%           
=========================================
  Files             ?      609           
  Lines             ?    45225           
  Branches          ?        0           
=========================================
  Hits              ?    16877           
  Misses            ?    26059           
  Partials          ?     2289

@tiborvass tiborvass force-pushed the buildkit-honor-daemon-dnsconfig branch 2 times, most recently from 23a8634 to 772d9d1 Compare June 26, 2019 20:27
build: buildkit now honors daemon's DNS config
a1cdd4b 
Signed-off-by: Tibor Vass <tibor@docker.com>
@tiborvass tiborvass force-pushed the buildkit-honor-daemon-dnsconfig branch from 772d9d1 to a1cdd4b Compare July 10, 2019 00:26
@tiborvass tiborvass changed the title [WIP] build: buildkit now honors daemon's DNS config build: buildkit now honors daemon's DNS config Jul 10, 2019
@tiborvass
Copy link
Contributor Author

Updated, PTAL @thaJeztah @tonistiigi

thaJeztah
thaJeztah approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

@tiborvass marked this one for cherry-pick; was that the intent?

@tiborvass
Copy link
Contributor Author

tiborvass commented Jul 15, 2019 •
edited

It’s something that is part of closing the gap between non-buildkit and BuildKit so I guess we could have it in a patch release yeah

@thaJeztah
Copy link
Member

all green

@thaJeztah thaJeztah merged commit c7bbb1c into moby:master Jul 16, 2019
@tiborvass tiborvass deleted the buildkit-honor-daemon-dnsconfig branch July 17, 2019 00:34
@thaJeztah thaJeztah mentioned this pull request Aug 8, 2019
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

@crosbymichael crosbymichael

Labels
area/builder process/cherry-picked status/4-merge
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tiborvass @thaJeztah @tonistiigi @crosbymichael @GordonTheTurtle