Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder/remotecontext: small refactor #40178

Open
wants to merge 2 commits into
base: master
from

Conversation

@thaJeztah
Copy link
Member

thaJeztah commented Nov 5, 2019

  • TestParseRemoteURL: use subtests
  • builder/remotecontext: use net/url instead of urlutil
    urlutil.IsUrl() was merely checking if the url had a http(s):// prefix, which is just as well handled through using url.Parse()
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

This comment has been minimized.

Copy link
Member Author

thaJeztah commented Nov 5, 2019

urlutil.IsUrl() was merely checking if the url had a http(s)://
prefix, which is just as well handled through using url.Parse()

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the thaJeztah:remote_context_refactor branch from 8f21b94 to 8659473 Nov 6, 2019
@thaJeztah

This comment has been minimized.

Copy link
Member Author

thaJeztah commented Nov 8, 2019

Failure is a known flaky;

FAIL: amd64.integration-cli TestDockerSwarmSuite/TestSwarmLockUnlockCluster (85.08s)

restarting CI

@thaJeztah

This comment has been minimized.

Copy link
Member Author

thaJeztah commented Nov 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.