Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03 backport] plugin: fix a double RLock bug #41274

Merged
merged 1 commit into from Jul 28, 2020
Merged

[19.03 backport] plugin: fix a double RLock bug #41274

merged 1 commit into from Jul 28, 2020

Conversation

thaJeztah
Copy link
Member

backport of #40588

@lzhfromustc @thaJeztah
plugin: fix a double RLock bug
32366de 
Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>
(cherry picked from commit 34837fe)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.13 milestone Jul 28, 2020
@thaJeztah thaJeztah requested a review from cpuguy83 as a code owner July 28, 2020 07:29
@thaJeztah
Copy link
Member Author

@AkihiroSuda @cpuguy83 @tiborvass ptal

@thaJeztah
Copy link
Member Author

Failure should now be fixed by #41271

== RUN   TestDockerSuite/TestRunNonRootUserResolvName
    --- FAIL: TestDockerSuite/TestRunNonRootUserResolvName (0.59s)
        cli.go:35: assertion failed: 
            Command:  /usr/local/cli/docker run --name=testperm --user=nobody busybox nslookup apt.dockerproject.org
            ExitCode: 1
            Error:    exit status 1
            Stdout:   Server:    10.100.0.2
            Address 1: 10.100.0.2 ip-10-100-0-2.ec2.internal
            
            
            Stderr:   nslookup: can't resolve 'apt.dockerproject.org'
            
            
            Failures:
            ExitCode was 1 expected 0
            Expected no error

@tiborvass tiborvass merged commit 22c458b into moby:19.03 Jul 28, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_Double_RLock branch July 28, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@cpuguy83 cpuguy83 Awaiting requested review from cpuguy83 cpuguy83 is a code owner

Assignees
No one assigned
Labels
area/plugins kind/bugfix PR's that fix bugs status/2-code-review
Projects
None yet
Milestone
19.03.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @tiborvass @AkihiroSuda @lzhfromustc