Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vagrantfile and remove it from all docs #4281

Merged
merged 1 commit into from
Feb 24, 2014

Conversation

unclejack
Copy link
Contributor

This removes the Vagrantfile and updates the documentation to remove the steps which explain how to install Docker in a VM via Vagrant.

This PR also modifies the Windows install guide to use boot2docker.

There are a few reasons for removing the Vagrantfile and the docs which explain how to install Docker via virtual machines using Vagrant:

  • Vagrant and VirtualBox need to be downloaded and installed on the machine; Vagrant was an unnecessary dependency for the EC2 example
  • The Vagrant boxes aren't provided via HTTPS and they're large downloads. They'd still remain large downloads even if we made our own images available via HTTPS.
  • Vagrant relies on virtual box guest additions to set up the virtual machines. This is a problem because the guest additions need to be kept up to date when upgrading VirtualBox.
  • The VirtualBox guest additions ISO file isn't available via HTTPS.
  • Provisioning a new Vagrant virtual machine takes a long time and Vagrant's VirtualBox VM hangs at the boot prompt on OS X sometimes. This can be fixed, but this doesn't fix the other problems.
  • The user has to download Vagrant and VirtualBox. The vagrant box needs to be downloaded as well if the user didn't already have everything set up and didn't use the Vagrant box we require.
  • Windows really needs a simple and easy to set up package. The guide required more steps to follow and tools to be set up on Windows.

@tianon
Copy link
Member

tianon commented Feb 21, 2014

LGTM

@jamtur01
Copy link
Contributor

  1. I'd add some mention of boot2docker in the FAQ.
  2. It seems odd to totally remove Windows before we have a solution for it. I'd leave it there and then replace it with an actual Windows package when we have such a beast.

@unclejack
Copy link
Contributor Author

@jamtur01 I'll prepare an alternative guide for Windows based on VirtualBox and boot2docker. Where do you think it'd be best to mention boot2docker in the FAQ?

@jamtur01
Copy link
Contributor

The same question you updated. Although @SvenDowideit it'd be worth popping in an FAQ question or two on boot2docker as well.

@jamtur01
Copy link
Contributor

Actually looking at the new Go based boot2docker we could probably write Windows install docs using that - @SvenDowideit?

@unclejack
Copy link
Contributor Author

@jamtur01 I've made the changes you've suggested.

@jamtur01
Copy link
Contributor

Broadly LGTM. /cc @metalivedev @SvenDowideit

@vieux
Copy link
Contributor

vieux commented Feb 21, 2014

I see vagrant in http://docs.docker.io/en/latest/contributing/devenvironment/

@vieux
Copy link
Contributor

vieux commented Feb 21, 2014

and in http://docs.docker.io/en/latest/

@vieux
Copy link
Contributor

vieux commented Feb 21, 2014

Shoud we grep the docs and remove completely each mention of vagrant ?


Installation
------------

.. include:: install_header.inc

.. include:: install_unofficial.inc
1. Install virtualbox from https://www.virtualbox.org - or follow this tutorial: http://www.slideshare.net/julienbarbier42/install-virtualbox-on-windows-7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think www.virtualbox.org is short enough to keep in the text, but Julien's tutorial URL is a bit long and would look better as a link to this tutorial by Julien Barbier

Same comment about links/URLs in the steps below.

@SvenDowideit
Copy link
Contributor

Yes, it looks like I'll be writing a boot2docker (go based) install document for windows - I'm looking for windows install disks to add to the other install-fest i'm doing on my new notebook ssd today

This removes the Vagrantfile and updates the documentation to remove
the steps which explain how to install Docker in a VM via Vagrant.

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (github: unclejack)
@unclejack
Copy link
Contributor Author

@metalivedev I've updated the PR and I've tried to make all the changes you've suggested. I've decided to try nested enumerated lists for the steps to be done in that dialog box.

@SvenDowideit This should be ready for you to review as well.

@SvenDowideit
Copy link
Contributor

very LGTM :)

@oxypwn
Copy link
Contributor

oxypwn commented Feb 22, 2014

Im interested how this will affect the current build environment. Convert the makefile to regular shellscript?

@unclejack
Copy link
Contributor Author

@pandrew The Makefile isn't going to be affected by this change, it'll work just like before.
Vagrant isn't going to be used any more. This is only a problem if you were running OS X or Windows and didn't set up boot2docker yet.

@crosbymichael
Copy link
Contributor

LGTM

2 similar comments
@jamtur01
Copy link
Contributor

LGTM

@creack
Copy link
Contributor

creack commented Feb 24, 2014

LGTM

creack added a commit that referenced this pull request Feb 24, 2014
Remove Vagrantfile and remove it from all docs
@creack creack merged commit 8cfa771 into moby:master Feb 24, 2014
@valentinedwv
Copy link

Future docs should not to clone the master branch if breaking changes are going to happen... please.

@unclejack unclejack deleted the remove_vagrantfile branch February 26, 2014 21:15
@inthecloud247
Copy link

I'm really surprised that Vagrant was completely removed here. I'm on Ubuntu, yet I still find it useful sometimes to develop docker containers using docker running within Vagrant. I think that it should still be an option...

this uses vagrant, for example: https://github.com/phusion/baseimage-docker

@gavioto
Copy link

gavioto commented May 8, 2014

I like Vagrant, but reasons presented here seems consistent. On the other hand, the comunity could develop third party tools to work with vagrant.

Could I suggest to create http://chocolatey.org/ script to install docker, and all necesary stuff in windows? Yes, chocolatey should be installed before, but it could be installed automatically from command line. So, in fact, it could be possible to insatll docker from a bat, and the sell, including Chocolatey and the Docker nuget package.

UPDATE: I have seen #1567 and continue writing on it. Sorry

@jamtur01
Copy link
Contributor

jamtur01 commented May 8, 2014

@gavioto We're building a boot2docker installer for Windows right now. Should be out by DockerCon (June 8th). Will wrap VirtualBox, Docker and other needed bits.

@gavioto
Copy link

gavioto commented May 8, 2014

Thanks for the info @jamtur01. DockerCon seems very interesting...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet