Jump to conversation
Unresolved conversations (3)
@thaJeztah thaJeztah Mar 10, 2025
Is this logged once, or for every container? If it's once, then `Warn` would be fine as well
...work/drivers/bridge/port_mapping_linux.go
robmry
@thaJeztah thaJeztah Mar 10, 2025
Micro-nit (if you'll be pushing again); looks like this one ended up separate from the other imports below
Outdated
...ion/networking/port_mapping_linux_test.go
thaJeztah robmry
@thaJeztah thaJeztah Mar 10, 2025
If we _do_ want to add some words around it, perhaps something like; ```suggestion v.Warnings = append(v.Warnings, "WARNING: DOCKER_INSECURE_NO_IPTABLES_RAW is set") ``` ```suggestion v.Warnings = append(v.Warnings, "WARNING: raw iptables rules are skipped because DOCKER_INSECURE_NO_IPTABLES_RAW is set") ``` The 'DOCKER_INSECURE_NO_IPTABLES_RAW is set` may be slightly nicer to indicate what's the case, but not sure about the "raw iptable rules are skipped", not sure if that's providing much context on its own.
Outdated
daemon/info_unix.go
robmry
Resolved conversations (0)