Fix archive/changes_test.go on FreeBSD #5467

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
10 participants
@kzys
Contributor

kzys commented Apr 29, 2014

These two commits are required for fixing the test.

@unclejack

This comment has been minimized.

Show comment
Hide comment
@unclejack

unclejack May 5, 2014

Contributor

Linux seems to be OK, but FreeBSD is running into some failures:

+ go test github.com/dotcloud/docker/archive
# testmain
clang: warning: argument unused during compilation: '-rdynamic'
--- FAIL: TestChangesDirsEmpty (0.01 seconds)
        changes_test.go:118: Reported changes for identical dirs: [{/dir1 0} {/d
--- FAIL: TestChangesDirsMutated (0.01 seconds)
        changes_test.go:253: unexpected change C /dir4
--- FAIL: TestApplyLayer (0.05 seconds)
        changes_test.go:290: invalid argument
FAIL
exit status 1
FAIL    _/root/docker/archive   0.086s

Tests failed: ./archive
Contributor

unclejack commented May 5, 2014

Linux seems to be OK, but FreeBSD is running into some failures:

+ go test github.com/dotcloud/docker/archive
# testmain
clang: warning: argument unused during compilation: '-rdynamic'
--- FAIL: TestChangesDirsEmpty (0.01 seconds)
        changes_test.go:118: Reported changes for identical dirs: [{/dir1 0} {/d
--- FAIL: TestChangesDirsMutated (0.01 seconds)
        changes_test.go:253: unexpected change C /dir4
--- FAIL: TestApplyLayer (0.05 seconds)
        changes_test.go:290: invalid argument
FAIL
exit status 1
FAIL    _/root/docker/archive   0.086s

Tests failed: ./archive
@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys May 5, 2014

Contributor

Thanks for reviewing. The third error should be fixed by #5454 IIRC.

Contributor

kzys commented May 5, 2014

Thanks for reviewing. The third error should be fixed by #5454 IIRC.

@vieux vieux added this to the 1.0 milestone May 15, 2014

@creack

This comment has been minimized.

Show comment
Hide comment
@creack

creack May 16, 2014

Contributor

LGTM. @unclejack can you take another look?

Contributor

creack commented May 16, 2014

LGTM. @unclejack can you take another look?

@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys May 17, 2014

Contributor

Would you mind if I rebase the branch against master just in case?

Contributor

kzys commented May 17, 2014

Would you mind if I rebase the branch against master just in case?

@creack

This comment has been minimized.

Show comment
Hide comment
@creack

creack May 19, 2014

Contributor

Go ahead :)

Contributor

creack commented May 19, 2014

Go ahead :)

@crosbymichael crosbymichael removed this from the 1.0 milestone May 19, 2014

kzys added some commits Apr 29, 2014

FreeBSD has lchmod(2)
Docker-DCO-1.1-Signed-off-by: Kato Kazuyoshi <kato.kazuyoshi@gmail.com> (github: kzys)
Don't compare Rdev for normal files
Docker-DCO-1.1-Signed-off-by: Kato Kazuyoshi <kato.kazuyoshi@gmail.com> (github: kzys)
@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys May 21, 2014

Contributor

Rebased.

Contributor

kzys commented May 21, 2014

Rebased.

@vbatts

This comment has been minimized.

Show comment
Hide comment
@vbatts

vbatts Jun 5, 2014

Contributor

LGTM

make test passes, and go test are ok on linux and freebsd

Contributor

vbatts commented Jun 5, 2014

LGTM

make test passes, and go test are ok on linux and freebsd

@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys Jun 24, 2014

Contributor

@unclejack Can you take a look?

Contributor

kzys commented Jun 24, 2014

@unclejack Can you take a look?

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jul 7, 2014

Collaborator
Collaborator

vieux commented Jul 7, 2014

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael

crosbymichael Jul 31, 2014

Contributor

@unclejack this one is for you now that you are the archive maintainer. Let me know if you need me to check out anything.

Contributor

crosbymichael commented Jul 31, 2014

@unclejack this one is for you now that you are the archive maintainer. Let me know if you need me to check out anything.

@tiborvass

This comment has been minimized.

Show comment
Hide comment
Collaborator

tiborvass commented Sep 23, 2014

@shykes

This comment has been minimized.

Show comment
Hide comment
@shykes

shykes Nov 1, 2014

Collaborator

Hi @kzys, congratulations, your PR is officially the oldest pull request currently open. Sorry about that.

After discussing with the other maintainers, we agreed that, before reviewing and merging FreeBSD patches, we really need to recruit an active FreeBSD maintainer to take responsibility for it (and develop the necessary tooling). Currently FreeBSD is not a supported platform, and nobody is available to change that, so for now the best thing to do is to close this.

However, if you are available to invest time in being our FreeBSD maintainer (or if you know someone who is), please let us know, we are interested!

Collaborator

shykes commented Nov 1, 2014

Hi @kzys, congratulations, your PR is officially the oldest pull request currently open. Sorry about that.

After discussing with the other maintainers, we agreed that, before reviewing and merging FreeBSD patches, we really need to recruit an active FreeBSD maintainer to take responsibility for it (and develop the necessary tooling). Currently FreeBSD is not a supported platform, and nobody is available to change that, so for now the best thing to do is to close this.

However, if you are available to invest time in being our FreeBSD maintainer (or if you know someone who is), please let us know, we are interested!

@shykes shykes closed this Nov 1, 2014

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 1, 2014

Member

Perhaps post a 'Ask HN' on Hacker News? "Docker is looking for a FreeBSD maintainer"

Member

thaJeztah commented Nov 1, 2014

Perhaps post a 'Ask HN' on Hacker News? "Docker is looking for a FreeBSD maintainer"

@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys Nov 1, 2014

Contributor

I had wedding and I was moved to the States last month. It made me too busy.

However I want to back Docker again! I'm not sure how much efforts are
required for being official. But I will update these pull requests soon.
Wait a sec.

Contributor

kzys commented Nov 1, 2014

I had wedding and I was moved to the States last month. It made me too busy.

However I want to back Docker again! I'm not sure how much efforts are
required for being official. But I will update these pull requests soon.
Wait a sec.

@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys Nov 1, 2014

Contributor

Ah, there are no opening pull requests. Okay.

I'd like to continue the work and I'm fine to be an official maintainer. Then what I need to do?

If you'd like to see the feasibility of FreeBSD support, before reviewing changes, I'm fine to continue the work on kzys/docker first.

Contributor

kzys commented Nov 1, 2014

Ah, there are no opening pull requests. Okay.

I'd like to continue the work and I'm fine to be an official maintainer. Then what I need to do?

If you'd like to see the feasibility of FreeBSD support, before reviewing changes, I'm fine to continue the work on kzys/docker first.

@unclejack

This comment has been minimized.

Show comment
Hide comment
@unclejack

unclejack Nov 2, 2014

Contributor

@kzys Congratulations for getting married and for moving to the US!

We're happy to hear you're willing to work on the FreeBSD support and make Docker work on FreeBSD as a daemon.

We hang out on Freenode in #docker-dev. I'd suggest dropping by that channel and hanging around so you can ping us whenever there's something you need to discuss, and so that we can ping you whenever we'd like to ask you a question. This isn't mandatory, but it would help make staying in touch with us a lot easier.

Ideally, we'd like to merge smaller PRs one by one to work towards the goal of fully supporting Docker on FreeBSD. This is much better than big PRs because merging monolithic PRs takes a long time. Large monolithic PRs are very likely to get rejected with a request to be broken down into multiple smaller ones.

Here are some immediately actionable next steps which would help with FreeBSD support:

  1. take a look at this ZFS graph driver to make sure we make it compatible with FreeBSD #7901 - it's currently linking against the zfs libs on Linux, that's probably not very portable
  2. get https://codereview.appspot.com/102640045/ committed to Go's code
  3. investigate other problems and incompatibilities between Docker's code and FreeBSD; work on and send PRs to fix these problems
Contributor

unclejack commented Nov 2, 2014

@kzys Congratulations for getting married and for moving to the US!

We're happy to hear you're willing to work on the FreeBSD support and make Docker work on FreeBSD as a daemon.

We hang out on Freenode in #docker-dev. I'd suggest dropping by that channel and hanging around so you can ping us whenever there's something you need to discuss, and so that we can ping you whenever we'd like to ask you a question. This isn't mandatory, but it would help make staying in touch with us a lot easier.

Ideally, we'd like to merge smaller PRs one by one to work towards the goal of fully supporting Docker on FreeBSD. This is much better than big PRs because merging monolithic PRs takes a long time. Large monolithic PRs are very likely to get rejected with a request to be broken down into multiple smaller ones.

Here are some immediately actionable next steps which would help with FreeBSD support:

  1. take a look at this ZFS graph driver to make sure we make it compatible with FreeBSD #7901 - it's currently linking against the zfs libs on Linux, that's probably not very portable
  2. get https://codereview.appspot.com/102640045/ committed to Go's code
  3. investigate other problems and incompatibilities between Docker's code and FreeBSD; work on and send PRs to fix these problems
@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys Nov 2, 2014

Contributor

Thanks @unclejack. Let me setup the channel after getting an internet connection :)

  1. It's good to know that someone is working on ZFS driver already! My FreeBSD work doesn't depend on ZFS, but I agree that ZFS is required for actually using Docker on FreeBSD.
  2. Got it. I pinged iant and he reviewed the change already. I will update the CR soon.
  3. Sure.
Contributor

kzys commented Nov 2, 2014

Thanks @unclejack. Let me setup the channel after getting an internet connection :)

  1. It's good to know that someone is working on ZFS driver already! My FreeBSD work doesn't depend on ZFS, but I agree that ZFS is required for actually using Docker on FreeBSD.
  2. Got it. I pinged iant and he reviewed the change already. I will update the CR soon.
  3. Sure.
@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Jul 3, 2015

Hey, all -- what's the overall status on FreeBSD support?

I see that the following have occurred:

Is there a roadmap, dev plan, or task list anywhere for FreeBSD support?

Hope this is still in the works!

oubiwann commented Jul 3, 2015

Hey, all -- what's the overall status on FreeBSD support?

I see that the following have occurred:

Is there a roadmap, dev plan, or task list anywhere for FreeBSD support?

Hope this is still in the works!

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jul 3, 2015

Member

@oubiwann actually, another contributor (@kvasdopil) is currently working on making Docker work on FreeBSD (see #13423). Looks to be stalled in #13542 at the moment (maintainers have been busy for DockerCon and the 1.7 release), but I'll see if I can get it moving again.

Member

thaJeztah commented Jul 3, 2015

@oubiwann actually, another contributor (@kvasdopil) is currently working on making Docker work on FreeBSD (see #13423). Looks to be stalled in #13542 at the moment (maintainers have been busy for DockerCon and the 1.7 release), but I'll see if I can get it moving again.

@kzys

This comment has been minimized.

Show comment
Hide comment
@kzys

kzys Jul 3, 2015

Contributor

Sorry about that. I haven't know that @kvasdopil is taking over the efforts. Awesome :)

Contributor

kzys commented Jul 3, 2015

Sorry about that. I haven't know that @kvasdopil is taking over the efforts. Awesome :)

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jul 3, 2015

Member

@kzys I know he's working on it, not sure if he's using the same approach.

Are you interested in helping? (if he needs help)

Member

thaJeztah commented Jul 3, 2015

@kzys I know he's working on it, not sure if he's using the same approach.

Are you interested in helping? (if he needs help)

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Jul 3, 2015

@thaJeztah Oh, man -- this is GREAT news! I can't want to try it out :-D
Thanks for the info!

On Fri, Jul 3, 2015 at 10:22 AM, Sebastiaan van Stijn <
notifications@github.com> wrote:

@oubiwann https://github.com/oubiwann actually, another contributor (
@kvasdopil https://github.com/kvasdopil) is currently working on making
Docker work on FreeBSD (see #13423
#13423). Looks to be stalled in
#13542 #13542 at the moment
(maintainers have been busy for DockerCon and the 1.7 release), but I'll
see if I can get it moving again.


Reply to this email directly or view it on GitHub
#5467 (comment).

oubiwann commented Jul 3, 2015

@thaJeztah Oh, man -- this is GREAT news! I can't want to try it out :-D
Thanks for the info!

On Fri, Jul 3, 2015 at 10:22 AM, Sebastiaan van Stijn <
notifications@github.com> wrote:

@oubiwann https://github.com/oubiwann actually, another contributor (
@kvasdopil https://github.com/kvasdopil) is currently working on making
Docker work on FreeBSD (see #13423
#13423). Looks to be stalled in
#13542 #13542 at the moment
(maintainers have been busy for DockerCon and the 1.7 release), but I'll
see if I can get it moving again.


Reply to this email directly or view it on GitHub
#5467 (comment).

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jul 3, 2015

Member

@oubiwann it may still take a while, I think he's only working on the basics so far. Best way to keep up is subscribing to the pull requests.

Member

thaJeztah commented Jul 3, 2015

@oubiwann it may still take a while, I think he's only working on the basics so far. Best way to keep up is subscribing to the pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment