Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CommandFactory and NsInit interface #5515

Merged
merged 8 commits into from May 1, 2014

Conversation

@crosbymichael
Copy link
Member

crosbymichael commented May 1, 2014

This PR contains more pre reqs for the runtime changes. It also simplifies the native driver a lot and reduces the complexity because there are less moving parts between libcontainer and native.

Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
This duplicates some of the Exec code but I think it it worth it because
the native driver is more straight forward and does not have the
complexity have handling the type issues for now.
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
No need to duplicate this information when we already have a
container.json file in the root of libcontainer
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
@crosbymichael

This comment has been minimized.

Copy link
Member Author

crosbymichael commented May 1, 2014

Happy @vieux! No more factories ;)

@crosbymichael

This comment has been minimized.

Copy link
Member Author

crosbymichael commented May 1, 2014

ping @vieux @creack can you review this? We can merge this first and i'll rebase @jpetazzo PR on top of it.

@vieux

This comment has been minimized.

Copy link
Collaborator

vieux commented May 1, 2014

#assignee=vieux

@vieux

This comment has been minimized.

Copy link
Collaborator

vieux commented May 1, 2014

LGTM

1 similar comment
@creack

This comment has been minimized.

Copy link
Contributor

creack commented May 1, 2014

LGTM

creack added a commit that referenced this pull request May 1, 2014
Remove CommandFactory and NsInit interface
@creack creack merged commit fe4a255 into moby:master May 1, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@creack creack deleted the crosbymichael:refactor-libcontainer2 branch May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.