Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page_description and page_keywords md meta to mkdocs html template #5516

Merged
merged 1 commit into from May 1, 2014

Conversation

@SvenDowideit
Copy link
Contributor

SvenDowideit commented May 1, 2014

Docker-DCO-1.1-Signed-off-by: Sven Dowideit SvenDowideit@fosiki.com (github: SvenDowideit)

Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@fosiki.com> (github: SvenDowideit)
@SvenDowideit

This comment has been minimized.

Copy link
Contributor Author

SvenDowideit commented May 1, 2014

@jamtur01 @ostezer this will render the .md file's

page_description: some stuff
page_keywords: list, of, words to, use
@SvenDowideit

This comment has been minimized.

Copy link
Contributor Author

SvenDowideit commented May 1, 2014

addresses the technical part of #5360

@samalba

This comment has been minimized.

Copy link
Contributor

samalba commented May 1, 2014

LGTM

cc @dhrp (this is to fix SEO on the doc site)

Thanks @SvenDowideit !

@jamtur01

This comment has been minimized.

Copy link
Contributor

jamtur01 commented May 1, 2014

LGTM

@ostezer

This comment has been minimized.

Copy link
Contributor

ostezer commented May 1, 2014

LGTM.
However, this does not close the issue #5360.
This just solves the technical problem.
We still need to amend the docs to have better and preferably useful descriptions and keywords.
Please do not close the issue.
Merging.

ostezer added a commit that referenced this pull request May 1, 2014
add page_description and page_keywords md meta to mkdocs html template
@ostezer ostezer merged commit c52bb90 into moby:master May 1, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@dhrp

This comment has been minimized.

Copy link
Contributor

dhrp commented May 1, 2014

Thanks!

@SvenDowideit SvenDowideit deleted the SvenDowideit:docs-meta-rendering branch Jun 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.