Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and racy "used" param from streamformatter #6150

Merged
merged 1 commit into from
Jun 2, 2014
Merged

Remove unused and racy "used" param from streamformatter #6150

merged 1 commit into from
Jun 2, 2014

Conversation

LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Jun 2, 2014

Also tests written

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jun 2, 2014

ping @unclejack @vieux

t.Fatal(err)
}
if msg.ID != "id" {
t.Fatalf("Status must be 'action', got: %s", msg.Status)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to match the condition... was this a copy-paste error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, as usual :) Thank you

Also tests written
Docker-DCO-1.1-Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com> (github: LK4D4)
@unclejack
Copy link
Contributor

LGTM

1 similar comment
@vieux
Copy link
Contributor

vieux commented Jun 2, 2014

LGTM

vieux added a commit that referenced this pull request Jun 2, 2014
Remove unused and racy "used" param from streamformatter
@vieux vieux merged commit 43b7af1 into moby:master Jun 2, 2014
@LK4D4 LK4D4 deleted the remove_used_from_streamformatter branch June 2, 2014 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants