Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and racy "used" param from streamformatter #6150

Merged
merged 1 commit into from Jun 2, 2014
Merged

Remove unused and racy "used" param from streamformatter #6150

merged 1 commit into from Jun 2, 2014

Conversation

@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Jun 2, 2014

Also tests written

@LK4D4
Copy link
Contributor Author

@LK4D4 LK4D4 commented Jun 2, 2014

t.Fatal(err)
}
if msg.ID != "id" {
t.Fatalf("Status must be 'action', got: %s", msg.Status)

This comment has been minimized.

@cyphar

cyphar Jun 2, 2014
Contributor

This doesn't seem to match the condition... was this a copy-paste error?

This comment has been minimized.

@LK4D4

LK4D4 Jun 2, 2014
Author Contributor

Yeah, as usual :) Thank you

@@ -120,7 +120,7 @@ func Apply(c *cgroups.Cgroup, pid int) (cgroups.ActiveCgroup, error) {
// plus the kernel has some problems with joining the memory cgroup at a later time.
properties = append(properties,
systemd1.Property{"MemoryAccounting", dbus.MakeVariant(true)},
systemd1.Property{"CPUAccounting", dbus.MakeVariant(true)},
//systemd1.Property{"CPUAccounting", dbus.MakeVariant(true)},

This comment has been minimized.

@crosbymichael

crosbymichael Jun 2, 2014
Contributor

Why is this here?

This comment has been minimized.

@LK4D4

LK4D4 Jun 2, 2014
Author Contributor

Hell, sorry, my "home" patch. Fixed

Also tests written
Docker-DCO-1.1-Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com> (github: LK4D4)
@unclejack
Copy link
Contributor

@unclejack unclejack commented Jun 2, 2014

LGTM

1 similar comment
@vieux
Copy link
Contributor

@vieux vieux commented Jun 2, 2014

LGTM

vieux added a commit that referenced this pull request Jun 2, 2014
Remove unused and racy "used" param from streamformatter
@vieux vieux merged commit 43b7af1 into moby:master Jun 2, 2014
1 check passed
1 check passed
@samalba
continuous-integration/travis-ci The Travis CI build passed
Details
@LK4D4 LK4D4 deleted the LK4D4:remove_used_from_streamformatter branch Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants