Clarify manpages on docker start #6182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainer When run on a container that is already running, docker always succeeds. This was an intentional change in v0.10; it previously caused an error. This commit clarifies the man pages to indicate this is intended behavior. Docker-DCO-1.1-Signed-off-by: Matthew Heon <mheon@redhat.com> (github: mheon)
|
LGTM - do you think this should also go into the |
|
That sounds like a good idea - this is the sort of thing that might be seriously confusing to those upgrading to a newer version. I'll add a commit for it. |
This behavior changed from v0.9 to v0.10, so document it to prevent any confusion. Docker-DCO-1.1-Signed-off-by: Matthew Heon <mheon@redhat.com> (github: mheon)
|
LGTM @jamtur01 @ostezer |
|
LGTM |
jamtur01
added a commit
that referenced
this pull request
Jun 5, 2014
Clarify manpages on docker start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Docker v0.10, when docker start was run on an already-started container, it failed with an error. This was changed in v0.10 (commit a03f83e), which caused some confusion from people accustomed to the previous behaviour. This patch clarifies in the man pages that this change is intentional.