Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go vet errors #6269

Closed
wants to merge 1 commit into from
Closed

Fix go vet errors #6269

wants to merge 1 commit into from

Conversation

LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Jun 8, 2014

I've run govet tool on docker repository and found some small errors. This patch fixes them.

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jun 11, 2014

rebased
ping @vieux @unclejack @crosbymichael

@vieux
Copy link
Contributor

vieux commented Jun 11, 2014

@LK4D4 can you rebase again ?

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jun 11, 2014

@vieux done

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jun 12, 2014

fixed vendor changes

@@ -28,8 +28,8 @@ func main() {
flag.PrintDefaults()
} else {
fmt.Printf("s/#hidden/-string: %s\n", str)
fmt.Printf("b: %b\n", b)
fmt.Printf("-bool: %b\n", b2)
fmt.Printf("b: %v\n", b)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use %t for boolean values.

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jun 12, 2014

@tiborvass thank you :)

Docker-DCO-1.1-Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com> (github: LK4D4)
@vieux vieux mentioned this pull request Jun 18, 2014
@unclejack
Copy link
Contributor

Merged via #6495

@unclejack unclejack closed this Jun 18, 2014
@LK4D4 LK4D4 deleted the vet_fixes branch June 18, 2014 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants