New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable `docker search` on private docker registry. #7495

Merged
merged 6 commits into from Aug 20, 2014

Conversation

Projects
None yet
7 participants
@sontags
Contributor

sontags commented Aug 9, 2014

The cli interface works similar to other registry related commands:

docker search foo # ... searches for foo on the official hub
docker search localhost:5000/foo # ... does the same for the private reg at localhost:5000

Signed-off-by: Daniel Menet membership@sontags.ch

Enable `docker search` on private docker registry.
The cli interface works similar to other registry related commands:

  docker search foo

... searches for foo on the official hub

  docker search localhost:5000/foo

... does the same for the private reg at localhost:5000

Signed-off-by: Daniel Menet <membership@sontags.ch>

@dmp42 dmp42 added the Distribution label Aug 9, 2014

@sontags

This comment has been minimized.

Show comment
Hide comment
@sontags

sontags Aug 9, 2014

Contributor

forgot to mention: this addresses issue #5061

Contributor

sontags commented Aug 9, 2014

forgot to mention: this addresses issue #5061

Expand hostname before passing it to NewRegistry()
Signed-off-by: Daniel Menet <membership@sontags.ch>
@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael

crosbymichael Aug 12, 2014

Contributor

ping @shin- @dmp42

Can you review this PR please?

Contributor

crosbymichael commented Aug 12, 2014

ping @shin- @dmp42

Can you review this PR please?

@dmp42

This comment has been minimized.

Show comment
Hide comment
@dmp42

dmp42 Aug 13, 2014

Contributor

LGTM - @shin- can you live test it and confirm?

Contributor

dmp42 commented Aug 13, 2014

LGTM - @shin- can you live test it and confirm?

@shin-

This comment has been minimized.

Show comment
Hide comment
@shin-

shin- Aug 15, 2014

Contributor
$ curl -I localhost:5000/_ping
HTTP/1.1 200 OK
Server: gunicorn/18.0
Date: Fri, 15 Aug 2014 14:14:12 GMT
Connection: keep-alive
X-Docker-Registry-Standalone: True
Expires: -1
Content-Type: application/json
Pragma: no-cache
Cache-Control: no-cache
Content-Length: 4
X-Docker-Registry-Version: 0.7.3
X-Docker-Registry-Config: dev

shin@ubuntuvb:~/work/docker$ docker search localhost:5000/test
NAME                DESCRIPTION   STARS     OFFICIAL   AUTOMATED
library/testspeed                 0                    

LGTM!

Contributor

shin- commented Aug 15, 2014

$ curl -I localhost:5000/_ping
HTTP/1.1 200 OK
Server: gunicorn/18.0
Date: Fri, 15 Aug 2014 14:14:12 GMT
Connection: keep-alive
X-Docker-Registry-Standalone: True
Expires: -1
Content-Type: application/json
Pragma: no-cache
Cache-Control: no-cache
Content-Length: 4
X-Docker-Registry-Version: 0.7.3
X-Docker-Registry-Config: dev

shin@ubuntuvb:~/work/docker$ docker search localhost:5000/test
NAME                DESCRIPTION   STARS     OFFICIAL   AUTOMATED
library/testspeed                 0                    

LGTM!

@shin-

This comment has been minimized.

Show comment
Hide comment
@shin-

shin- Aug 15, 2014

Contributor

@sontags Can you rebase? =)

Contributor

shin- commented Aug 15, 2014

@sontags Can you rebase? =)

vieux and others added some commits Aug 15, 2014

Enable `docker search` on private docker registry.
The cli interface works similar to other registry related commands:

  docker search foo

... searches for foo on the official hub

  docker search localhost:5000/foo

... does the same for the private reg at localhost:5000

Signed-off-by: Daniel Menet <membership@sontags.ch>
Expand hostname before passing it to NewRegistry()
Signed-off-by: Daniel Menet <membership@sontags.ch>
resolved merge conflict
Signed-off-by: Daniel Menet <membership@sontags.ch>
@sontags

This comment has been minimized.

Show comment
Hide comment
@sontags

sontags Aug 16, 2014

Contributor

@shin- rebased

Contributor

sontags commented Aug 16, 2014

@shin- rebased

shin- added a commit that referenced this pull request Aug 20, 2014

Merge pull request #7495 from sontags/enable_search_on_private_reg
Enable `docker search` on private docker registry.

@shin- shin- merged commit 2eb2699 into moby:master Aug 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@shin-

This comment has been minimized.

Show comment
Hide comment
@shin-

shin- Aug 20, 2014

Contributor

Thanks!

Contributor

shin- commented Aug 20, 2014

Thanks!

@sontags sontags deleted the sontags:enable_search_on_private_reg branch Aug 22, 2014

@parente

This comment has been minimized.

Show comment
Hide comment
@parente

parente Aug 24, 2014

With nginx proxying for a private registry and basic auth enabled, I'm getting 401s when trying to search. Should this include auth headers?

parente commented Aug 24, 2014

With nginx proxying for a private registry and basic auth enabled, I'm getting 401s when trying to search. Should this include auth headers?

@shin-

This comment has been minimized.

Show comment
Hide comment
@shin-

shin- Aug 27, 2014

Contributor

@parente Most certainly! Would you like to submit a patch? =)

Contributor

shin- commented Aug 27, 2014

@parente Most certainly! Would you like to submit a patch? =)

@shin- shin- referenced this pull request Aug 27, 2014

Closed

Custom Docker index #3516

@shayke

This comment has been minimized.

Show comment
Hide comment
@shayke

shayke Nov 18, 2014

Can you please guide me to the credentials headers? I'll try to submit a patch.

shayke commented Nov 18, 2014

Can you please guide me to the credentials headers? I'll try to submit a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment