-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove circleci workflow #3114
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
d6944a3
to
0e914df
Compare
Some flaky tests: https://github.com/moby/swarmkit/actions/runs/4114820437/jobs/7102711665#step:5:75
Already tracked in #2559 And integration tests panics: https://github.com/moby/swarmkit/actions/runs/4114820437/jobs/7102712007#step:5:14553
|
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
0e914df
to
64c0f52
Compare
Codecov Report
@@ Coverage Diff @@
## master #3114 +/- ##
===========================================
+ Coverage 0 61.75% +61.75%
===========================================
Files 0 153 +153
Lines 0 31099 +31099
===========================================
+ Hits 0 19206 +19206
- Misses 0 10358 +10358
- Partials 0 1535 +1535 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
follow-up #3100
- What I did
Our GitHub Actions workflows are up for quite some time and look to work fine so let's remove CircleCI 🔫
Also I see CircleCI complains again when checking out the repo: https://app.circleci.com/pipelines/github/moby/swarmkit/578/workflows/835dd771-7346-4845-87b3-2da849f152ad/jobs/10967?invite=true#step-101-81
When merged, maintainers having access to the repo settings should cleanup webhooks and GitHub Apps related to CircleCI. (cc @dperny @neersighted @corhere @thaJeztah)
- How I did it
Remove CircleCI workflow
- How to test it
- Description for the changelog