Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `is being closed.` logs in proxystream #494

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@ebriney
Copy link
Contributor

ebriney commented Nov 8, 2019

They happen every time the client named pipe do a close and it don't hide any errors

(it's quite similar to is not connected filtering)

 - they happen every time the client named pipe do a close

Signed-off-by: ebriney <emmanuel.briney@docker.com>
@djs55
djs55 approved these changes Nov 8, 2019
Copy link
Collaborator

djs55 left a comment

LGTM!

@djs55

This comment has been minimized.

Copy link
Collaborator

djs55 commented Nov 8, 2019

The CircleCI and Appveyor CIs are both irrelevant to this PR: it should be tested by travis. I think it's safe to merge.

@djs55 djs55 merged commit 3e2e3f2 into moby:master Nov 8, 2019
2 of 4 checks passed
2 of 4 checks passed
ci/circleci: build Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dco-signed All commits are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.