lint all the things #2525

Closed
boneskull opened this Issue Oct 10, 2016 · 0 comments

Projects

None yet

1 participant

@boneskull
Member

semistandard is in place; I'm going to fix the rest of the issues across the codebase in skipped files.

currently we're skipping the tests (which are a mess). there's also a few other issues (such as strict mode) scattered about.

@boneskull boneskull added the qa label Oct 10, 2016
@boneskull boneskull self-assigned this Oct 10, 2016
@boneskull boneskull added a commit that referenced this issue Oct 10, 2016
@boneskull boneskull lint the hell out of the javascript; closes #2525
- mostly whitespace changes
- add `'use strict';` everywhere
- fix problems with unused variables, bad variable names, multiple declarations, unreachable code, yoda expressions, error handling, instantiation, etc.
- add a few eslint directives to avoid rules when needed
- switch to YAML eslint configs
- remove `test/` from `.eslintignore`
- add `mocha.js` to `.eslintignore`
- add userland `assert` as dev dependency (as is recommended)
- rename `test/fixture-expect.js` to `test/setup.js`; add global `assert` here
- add `assert` and `run` globals to `test/`'s eslint config
- update `test/mocha.opts` as appropriate
- update `lint` target in `Makefile`
- update eslint environments as appropriate
c21e380
@boneskull boneskull added a commit that closed this issue Oct 10, 2016
@boneskull boneskull lint the hell out of the javascript; closes #2525
- mostly whitespace changes
- add `'use strict';` everywhere
- fix problems with unused variables, bad variable names, multiple declarations, unreachable code, yoda expressions, error handling, instantiation, etc.
- add a few eslint directives to avoid rules when needed
- switch to YAML eslint configs
- remove `test/` from `.eslintignore`
- add `mocha.js` to `.eslintignore`
- add userland `assert` as dev dependency (as is recommended)
- rename `test/fixture-expect.js` to `test/setup.js`; add global `assert` here
- add `assert` and `run` globals to `test/`'s eslint config
- update `test/mocha.opts` as appropriate
- update `lint` target in `Makefile`
- update eslint environments as appropriate
2bb2b9f
@boneskull boneskull closed this in 2bb2b9f Oct 10, 2016
@keylocation-bot keylocation-bot referenced this issue in singapore/changelog Jan 11, 2017
Merged

Update dependency mocha to version 3.x #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment