New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netlify should only deploy when repo is tagged #3206
Comments
yeah I guess we can automate a branch push upon release |
For now let's just use a If there isn't a module on npm to do this, let's publish one. |
Just found this issue while trying to find out whether netlify have built-in support for release only on tags. Apparently, they don't which I think is mad. But my workaround for pydantic is to setup netlify to deploy a fictional branch I think that's more elegant than manually pushing to a branch. |
@samuelcolvin thanks for the tip! |
The lodash.com has a setup where the docs are availabel for the latest version of each major version release. This is using jekyll and netlify for hosting. Maybe there is inspiration to be found here: https://github.com/lodash/lodash.com/blob/master/_config.yml#L6-L9 |
I tried this:
This doesn't work, unfortunately, because of the disabled auto-publishing. Netlify's API has an endpoint to lock/unlock auto-publishing, however. I'll see what I can do with this. If I can't figure it out, we'll just have to create a branch for doc publishing, and update that branch every time we tag a release (or automate it). |
OK, yeah, in order to make that happen properly I'd need to either create a GitHub app or action. The former is more work than I'm willing to do atm (though using Probot would be a great place to start), and the later is still in private beta, so whatever. Branches it is for now. I'll configure netlify to only publish, say, the |
Maybe you could use GitHub Actions https://github.com/netlify/actions ?
… |
Created an issue for someone to look at #4117 |
@Munter when we merge changes into
master
which have documentation updates, those updates go live, even if the features they describe aren't yet in Mocha.I'd like to have it deploy when:
(ideally both)
Is that doable?
The text was updated successfully, but these errors were encountered: