feature(mocha/grep): improve grep - issue #808 #1650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://travis-ci.org/mochajs/mocha/jobs/38422941 The only problem in this error is that npm v1.2 doesn’t support `^` version specifier. It's not the problem of Node v0.8 itself. So I updated the installation command to install the latest version of npm, before installing the dependencies of mocha.
Users may register `Runnable`s as asynchronous in one of two ways: - Via callback (by defining the body function to have an arity of one) - Via promise (by returning a Promise object from the body function) When both a callback function is specified *and* a Promise object is returned, the `Runnable`'s resolution condition is ambiguous. Practically speaking, users are most likely to make this mistake as they transition between asynchronous styles. Currently, Mocha silently prefers the callback amd ignores the Promise object. Update the implementation of the `Runnable` class to fail immediately when the test resolution method is over-specified in this way.
# By Shinnosuke Watanabe # Via Shinnosuke Watanabe * 'travis' of https://github.com/shinnn/mocha: Require npm version which supports `^` specifier
…v3.0.0 # By Rob Loach # Via Rob Loach * 'update/glob' of https://github.com/RobLoach/mocha: Update glob to 4.0.6
This results in a slight change to the behavior of --async-only: instead of failing immediately, check to see if the test returned a promise (or otherwise failed) before complaining about not having a done callback.
* commit '7657cb11d960cf2cd8407b256019b2e34dc93328': Allow --async-only to be satisfied by returning a promise
a8m
force-pushed
the
improve-grep-issue-808
branch
from
a7085b1
to
d640a53
Compare
a8m
force-pushed
the
improve-grep-issue-808
branch
from
d640a53
to
f9fad1b
Compare
|
/cc @mochajs/mocha |
|
LGTM! :) Some might argue that it breaks BC, and would require a major bump. e.g.: it('/test/i', function() {});
it('test', function() {});with something like |
|
I couldn't take a look at it yet. Def break BC, but since we have other changes that do so too we can just ship them together in the next major. Thanks for the work @a8m! :) |
Throw an exception when timeout too large.
|
@a8m possible to rebase against branch |
a8m
force-pushed
the
improve-grep-issue-808
branch
from
6a9b45d
to
8196edc
Compare
|
Rebased. but it seems to be causing an error on Travis. |
|
old npm version carret issue |
|
Yep, not an actual issue. @a8m great feature! Let's merge and ship asap :) |
* commit '3b02d830c0c5f20c5be9acaa9ef45b824bcbf965': (29 commits) Add cross-frame compatible Error checking for fail Remove moot `version` property from bower.json HISTORY: fix typo in 2.2.5 HISTORY: improve 2.2.5 changelog removing duplicate flags adding additional iojs flags Prevent default browser behavior for failure/pass links Removes return statement irt mochajs#1700. Removes accidentally commited test.js Add support of --harmony_arrow_functions V8 option Release 2.2.5 Upgrade jsdiff to v1.4.0 fix 'location is not defined' error Update json-stream.js Sanity check: update fixtures/regression/issue-1327.js to be closer to orig test Fix diff colors use a valid SPDX license identifier Add integration tests Handling of error.htmlMessage in the HTML reporter Split message and stack into two separate variables fix(utils/stringify): fix issue mochajs#1660 ... Conflicts: test/acceptance/misc/asyncOnly.js
jbnicolai
force-pushed
the
master
branch
3 times, most recently
from
2f458ab
to
2952eca
Compare
|
@a8m this still needs to be rebased... not sure what's happening here. |
* master: (27 commits) Remove TODO from Browserify transition Build using Browserify Rework hook error tests to actually assert Move hook error test to integration in prep for rewrite Fix 1766: stackfilter should not ignore node_modules Remove __proto__ parsing from browser build scripts Replace __proto__ with lodash.create Removes heading newline. support escaped spaces in cli options Fixes indentation. Simplifies split regex, the filter already catches empty args. Removes unneeded trim, the filter does the same. Simplifies filter by truthy values. add lint check to test-all target. YES! remove dupe in contributors list lock down supports-color dependency lint runner.js Escape test/suite title for re in html reporter Remove npm version from engines field CI: Update npm when < 1.3.7 ... Conflicts: .travis.yml lib/runnable.js
Add the ability to pass grep as a regexp-like string. (query in the browser or flag in the cli). This improvement gives you pass a regexp that including a flag, and solved mochajs#808 as well.
a8m
force-pushed
the
improve-grep-issue-808
branch
from
8196edc
to
194f19e
Compare
|
Replaced with #1808(rebased on top of v3.0.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to pass
grepas a regexp-like string. (query in the browser or flag in the cli).This improvement gives you pass a regexp that including flags, and solved #808 as well.
e.g: