Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #2628 allowing to override the default test suite name of… #2676

Merged
merged 3 commits into from Sep 28, 2017

Conversation

@ngeor
Copy link
Contributor

ngeor commented Jan 19, 2017

Fixing issue #2628 allowing to override the default test suite name of the xunit reporter.

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Jan 19, 2017

CLA assistant check
All committers have signed the CLA.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage increased (+0.04%) to 76.82% when pulling bf88a21 on ngeor:xunit-custom-suite-name-2628 into 52a1957 on mochajs:master.

ngeor and others added 2 commits Jan 19, 2017
… the xunit reporter.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 25, 2017

Coverage Status

Coverage increased (+0.02%) to 88.209% when pulling 2571d8d on ngeor:xunit-custom-suite-name-2628 into a2fc76c on mochajs:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 25, 2017

Coverage Status

Coverage increased (+0.02%) to 88.209% when pulling d576434 on ngeor:xunit-custom-suite-name-2628 into a2fc76c on mochajs:master.

@boneskull

This comment has been minimized.

Copy link
Member

boneskull commented Jul 31, 2017

this looks good. it should go into v3.6.0 or v4.0.0, whichever comes first.

@boneskull

This comment has been minimized.

Copy link
Member

boneskull commented Jul 31, 2017

@ngeor thanks!

@ScottFreeCode

This comment has been minimized.

Copy link
Contributor

ScottFreeCode commented Sep 22, 2017

Should we update the assertion library in this to be the same one used by the existing tests for this reporter, or should we merge and update to use the same assertion library afterward?

@boneskull boneskull merged commit de68250 into mochajs:master Sep 28, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 88.209%
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.