Fixes #156 and #157 IE6-7-8 specific styles and non-canvas progress reporter for IE #387

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@brendannee
Contributor

Updated styles to fix layout bug in IE5.5 - IE9. Replaced unicode
characters with entities in CSS. Added a div-based progress reporter
when canvas isn't available. Added a class to #mocha for fallback
and IE specific styles to show pass fail status (color coded)

@brendannee brendannee Fixes #156 and #157 IE6-7-8 specific styles and non-canvas progress r…
…eporter for IE

Updated styles to fix layout bug in IE5.5 - IE9.  Replaced unicode
characters with entities in CSS. Added a div-based progress reporter
when canvas isn't available.  Added a class to `#mocha` for fallback
and IE specific styles to show pass fail status (color coded)
04914fa
@tj tj commented on an outdated diff Apr 13, 2012
if (canvas.getContext) {
ctx = canvas.getContext('2d');
progress = new Progress;
+ } else {
+ root.className = 'fallback';
+ progressBar = document.createElement('div');
+ items[0].appendChild(progressBar);
+ progressBar.innerHTML = '<div class="bar"><div class="innerBar"></div></div><span></span>';
+ bar = progressBar.getElementsByTagName('div')[0];
+ innerBar = bar.getElementsByTagName('div')[0];
+ innerText = progressBar.getElementsByTagName('span')[0];
@tj
tj Apr 13, 2012 Contributor

hmm I think personally I would rather just ignore any kind of progress bar when canvas isnt available just so we dont clutter this reporter too much more for legacy browsers

brendannee added some commits Apr 14, 2012
@brendannee brendannee Merge conflict fixes 63ef5dd
@brendannee brendannee Removed fallback progressbar for IE
Kept IE fallback styles to fix alignment issue and show pass/fail (IE
does support css :: pseudo selectors)
66ae293
@brendannee
Contributor

Good call - I removed the fallback progress bar, but kept the IE css fixes for alignment and showing pass/fail status

@tj
Contributor
tj commented Jun 17, 2012

This issue has been inactive for over 1 month so I'm closing it. If you think it's still an issue re-open. - tjbot

@tj tj closed this Jun 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment