New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add services's logo to both website and Readme #3627 #4036
Conversation
e22dfec
to
f37c829
Compare
f37c829
to
9b76a48
Compare
README.md
Outdated
[![MochaJS Sponsors](https://opencollective.com/mochajs/sponsor/19/avatar)](https://opencollective.com/mochajs/sponsor/19/website) | ||
[![MochaJS Sponsors](./docs/images/jetbrains-logo.png)](https://www.jetbrains.com/) | ||
[![MochaJS Sponsors](./docs/images/wallabyJs-logo.png)](https://wallabyjs.com/) | ||
[![MochaJS Sponsors](./docs/images/saucelabs-logo.png)](https://saucelabs.com/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separeting these logos from opencollective is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I will separate it, thank you :)
docs/_includes/default.html
Outdated
target="_blank" | ||
> | ||
<img | ||
src="images/openjsf-logo.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use svg logo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to,
Here are the reasons I changed the file from svg to png.
-
image resize problem
in Readme.md I wasn't able to use code below to resize file
(1) ![](url path =250x250) (2) ![](url path | width=100) (3) ![](url path){ width: 200px; }
So if I want to resize file , all I have to do is to use .
but in Readme, All contents are written in markdown language.
I don't want to break it because of my code. -
file path problem
If I used img tag, I couldn't get the image using relative path.
like below
'' src='./docs/images/someimages.png' ''
If I wanted to use file in docs/images/
https://raw.githubusercontent.com/mochajs/mocha/master/docs/images/matomo-logo.png
I had to use file path above. but as far as svg file is concerned, I wasn't able to get the right path to get the file.
so I just decided to make new file with the size I want. so the file turns out into png.
if I missed something, please let me know, thank you for the feedback.
I really appreciate it.
1d2fc53
to
5f8df08
Compare
I added services logo to both Readme and Website. Description of the Change1. Document I modified files below
2. Readme
Additional Informationregarding Readme, the position of logos look a little bit awkward. in fact I wanted to alter logos especially for Readme
so I just did my best to look them better as soon as I can. Thank you :) |
this has been sitting for a long time, I apologize. not sure we can use it in its current state though... please let us know if you want to pursue this further. marking stale |
Hi.
I added services's logo to both website and Readme as mentioned in #3627
I modified files below