Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds BigInt support to stringify util function. #4112
Description of the Change
Fixes #4090, adds a new case to the _stringify function in utils so it can handle the BigInt case.
There were two choices considered in the issue
Why should this be in core?
Nice way of representing BigInts in errors.
Support for Stringify-ing BigInts
I had to add
it could be a mismatch between username / email address.
is there something i am missing?
From what i see, the CI runs tests only on different NodeJs versions, Node 8 doesn't support BigInts either but I only added a new case to the stringify function, in that case it uses the toString function to create the representation of the BigInt, so the code it's never instantiating a BigInteger, just knows how to handle one if it ever receives it.