Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "fixture flowchart" to docs #4440

Merged
merged 2 commits into from Oct 12, 2020
Merged

Conversation

@boneskull
Copy link
Member

@boneskull boneskull commented Sep 9, 2020

  • also add some references to global fixtures

@Munter You know more about web stuff than I do. Is this a reasonable way to use an SVG? In particular, I wanted to make portions of it clickable, and couldn't figure out how to do that without embedding the <svg> into the page.

@boneskull boneskull requested review from Munter and craigtaub Sep 9, 2020
@boneskull boneskull self-assigned this Sep 9, 2020
@coveralls
Copy link

@coveralls coveralls commented Sep 9, 2020

Coverage Status

Coverage increased (+0.02%) to 94.078% when pulling 4fb2bb7 on boneskull/global-fixture-updates into f24f190 on master.

also add some references to global fixtures

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull force-pushed the boneskull/global-fixture-updates branch from 4c72600 to 7b94d86 Oct 9, 2020
@boneskull
Copy link
Member Author

@boneskull boneskull commented Oct 9, 2020

OK, I think I've addressed the responsiveness issue. I've also added a assets/mocha-fixture-wizard.sketch file to the repo

Copy link
Member

@outsideris outsideris left a comment

Including SVG is broken.

This flowchart will help you decide which of [hooks], [root hook plugins] or
[global fixtures] you should use.

{% include fixture-wizard.html %}

This comment has been minimized.

@outsideris

outsideris Oct 9, 2020
Member

Including HTML is not handled properly and SVG is broken.
I don't know why even I checked it.

This comment has been minimized.

@boneskull

boneskull Oct 9, 2020
Author Member

ohh I know what happened. prettier broke it. I am not sure if this is a bug in prettier or liquid or eleventy, but when prettier reformats it, the svg breaks.

This comment has been minimized.

@boneskull

boneskull Oct 9, 2020
Author Member

OK, wrapping the svg in a div works. I think this is an 11ty bug

This comment has been minimized.

@boneskull

boneskull Oct 9, 2020
Author Member

- added source `.sketch` file to repo
- enabled skip of supporter image download in 11ty via env var `MOCHA_DOCS_SKIP_IMAGE_DOWNLOAD` for faster iteration
- made the links underline on hover

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull force-pushed the boneskull/global-fixture-updates branch from 7b94d86 to 4fb2bb7 Oct 9, 2020
@boneskull boneskull requested a review from outsideris Oct 9, 2020
@boneskull boneskull merged commit 478ca6a into master Oct 12, 2020
38 checks passed
38 checks passed
Retrive head commit message
Details
Retrive head commit message
Details
Check to skip CI
Details
Check to skip CI
Details
Smoke [Node.js v10 / ubuntu-latest]
Details
Smoke [Node.js v10 / ubuntu-latest]
Details
Smoke [Node.js v12 / ubuntu-latest]
Details
Smoke [Node.js v12 / ubuntu-latest]
Details
Smoke [Node.js v14 / ubuntu-latest]
Details
Smoke [Node.js v14 / ubuntu-latest]
Details
Smoke [Node.js v10 / windows-2019]
Details
Smoke [Node.js v10 / windows-2019]
Details
Smoke [Node.js v12 / windows-2019]
Details
Smoke [Node.js v12 / windows-2019]
Details
Smoke [Node.js v14 / windows-2019]
Details
Smoke [Node.js v14 / windows-2019]
Details
ESLint Check
Details
ESLint Check
Details
Markdown Check
Details
Markdown Check
Details
Node.js [v10 / ubuntu-latest]
Details
Node.js [v10 / ubuntu-latest]
Details
Node.js [v12 / ubuntu-latest]
Details
Node.js [v12 / ubuntu-latest]
Details
Node.js [v14 / ubuntu-latest]
Details
Node.js [v14 / ubuntu-latest]
Details
Node.js [v10 / windows-2019]
Details
Node.js [v10 / windows-2019] Node.js [v10 / windows-2019]
Details
Node.js [v12 / windows-2019]
Details
Node.js [v12 / windows-2019] Node.js [v12 / windows-2019]
Details
Node.js [v14 / windows-2019]
Details
Node.js [v14 / windows-2019] Node.js [v14 / windows-2019]
Details
ESLint Results Checks Complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.959%
Details
licence/cla Contributor License Agreement is signed.
Details
netlify/mocha/deploy-preview Deploy preview ready!
Details
@boneskull boneskull added this to the v8.2.0 milestone Oct 12, 2020
@boneskull boneskull added semver-minor and removed semver-patch labels Oct 12, 2020
@boneskull
Copy link
Member Author

@boneskull boneskull commented Oct 12, 2020

(semver minor b/c it references other stuff that will land in a minor)

@boneskull boneskull deleted the boneskull/global-fixture-updates branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.