Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert deprecation of 'EVENT_SUITE_ADD_*' events #4764

Merged
merged 2 commits into from Oct 3, 2021

Conversation

beatfactor
Copy link
Contributor

@beatfactor beatfactor commented Oct 3, 2021

Description of the Change

Other projects (such as Nigthwatch.js) may be relying on these events in order to be able to extend the test suite object during the parsing cycle.

Alternate Designs

None.

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

These is a minimal risk change and it has been reviewed in #4760.

@juergba juergba added integration semver-patch labels Oct 3, 2021
@juergba juergba linked an issue Oct 3, 2021 that may be closed by this pull request
@coveralls
Copy link

@coveralls coveralls commented Oct 3, 2021

Coverage Status

Coverage decreased (-0.01%) to 94.428% when pulling 5d65912 on beatfactor:undeprecate-suite-add-event into 0ea732c on mochajs:master.

@juergba juergba added the run-browser-test label Oct 3, 2021
@github-actions github-actions bot removed the run-browser-test label Oct 3, 2021
juergba
juergba approved these changes Oct 3, 2021
Copy link
Member

@juergba juergba left a comment

@beatfactor thank you.

@juergba juergba merged commit 111467f into mochajs:master Oct 3, 2021
1 check passed
@juergba juergba changed the title Remove listing of EVENT_SUITE_ADD* events as deprecated (#4760) Revert deprecation of 'EVENT_SUITE_ADD_*' events Oct 3, 2021
@juergba juergba added this to the next milestone Oct 3, 2021
@juergba
Copy link
Member

@juergba juergba commented Oct 3, 2021

re decreasing coverage: as usual ... when removing code, calculated coverage is nonsense.

@beatfactor beatfactor deleted the undeprecate-suite-add-event branch Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants