Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: update 'prettier` #4776

Merged
merged 1 commit into from Oct 26, 2021
Merged

devDeps: update 'prettier` #4776

merged 1 commit into from Oct 26, 2021

Conversation

juergba
Copy link
Member

@juergba juergba commented Oct 25, 2021

Description

  • prevent peer dependency error by prettier:
mocha@9.1.3 D:\mocha-fork\mocha
├─┬ eslint-plugin-prettier@4.0.0
│ └── prettier@1.19.1 deduped invalid: ">=2.0.0" from node_modules/eslint-plugin-prettier
└── prettier@1.19.1 invalid: ">=2.0.0" from node_modules/eslint-plugin-prettier

npm ERR! code ELSPROBLEMS
npm ERR! invalid: prettier@1.19.1 D:\mocha-fork\mocha\node_modules\prettier
  • many changes are forced by a new rule for function synthax: function() {} => function () {}
    There is no option to customize this setting (prettier is an opinionated code formatter).

@juergba juergba self-assigned this Oct 25, 2021
@juergba juergba added chore dependencies semver-patch labels Oct 25, 2021
@juergba juergba requested a review from Oct 25, 2021
Copy link
Member

@outsideris outsideris left a comment

LGTM

@outsideris
Copy link
Member

@outsideris outsideris commented Oct 25, 2021

This PR includes a commit in #4775. (I think you already know it.)

@juergba juergba merged commit ac43029 into master Oct 26, 2021
26 checks passed
@juergba juergba deleted the juergba/prettier branch Oct 26, 2021
@juergba juergba added this to the next milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants