Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node v17 into ci matrix #4777

Merged
merged 3 commits into from Oct 27, 2021
Merged

Add Node v17 into ci matrix #4777

merged 3 commits into from Oct 27, 2021

Conversation

outsideris
Copy link
Member

@outsideris outsideris commented Oct 25, 2021

Node 17 is a new Current version. So, mocha will run tests on Node v17.

And Netlify runs on node 12, but 12 is a pretty old version.
I updated it to Node 16. v16 will be the new LTS version soon.

Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Member Author

@outsideris outsideris commented Oct 25, 2021

I will check Netlify build time differences between node v12 and v16.

@coveralls
Copy link

@coveralls coveralls commented Oct 25, 2021

Coverage Status

Coverage remained the same at 94.428% when pulling d331adb on outsideris:node-version into 28b4824 on mochajs:master.

@outsideris
Copy link
Member Author

@outsideris outsideris commented Oct 25, 2021

There was some errors I didn't expect when netlify build docs with Node v16.
I will test it in a different PR.

@outsideris outsideris requested a review from Oct 25, 2021
@outsideris outsideris changed the title Node version Add Node v17 into ci matrix Oct 25, 2021
Copy link
Member

@juergba juergba left a comment

The Node tests don't run on v17.

.github/workflows/mocha.yml Show resolved Hide resolved
outsideris added 2 commits Oct 27, 2021
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Member Author

@outsideris outsideris commented Oct 27, 2021

I add v17 to test matrix.

And set v16 our default version on CI because node v16 LTS have released.

@juergba juergba merged commit a99d40c into mochajs:master Oct 27, 2021
25 checks passed
@juergba juergba added chore qa semver-patch labels Oct 27, 2021
@juergba juergba added this to the next milestone Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore qa semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants