Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of Node v12 #4845

Merged
merged 1 commit into from Mar 15, 2022
Merged

Drop support of Node v12 #4845

merged 1 commit into from Mar 15, 2022

Conversation

juergba
Copy link
Member

@juergba juergba commented Mar 12, 2022

Description of the Change

We drop support of Node v12 which will be end-of-life: 2022-04-30

@juergba juergba self-assigned this Mar 12, 2022
@juergba juergba added qa involving Mocha's tests, coverage, or CI config semver-major implementation requires increase of "major" version number; "breaking changes" node.js command-line-or-Node.js-specific labels Mar 12, 2022
@juergba juergba added this to the v10.0.0 milestone Mar 12, 2022
@juergba juergba requested a review from a team Mar 12, 2022
@giltayar
Copy link
Contributor

giltayar commented Mar 12, 2022

A bit premature, no? End of April is more than a month and a half away.

There's a lot of test code that we can remove: test code that adds the --experimental-es-modules (or some such), and which we don't need anymore in Node 14. Cleans up things a bit.

I can do that once this lands.

@juergba
Copy link
Member Author

juergba commented Mar 12, 2022

A bit premature, no? End of April is more than a month and a half away.

No, I don't think so, our milestone v10.0.0 has due-date of May-01-2022. There is a lot to do until then as e.g. dropping IE11, we will need those six weeks. The creation date of this PR is not identical with the release date of v10.0.0.

There's a lot of test code that we can remove [...] I can do that once this lands.

Yes, please. And also add .js to the extensionless bin/mocha executable.

@giltayar
Copy link
Contributor

giltayar commented Mar 12, 2022

So LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node.js command-line-or-Node.js-specific qa involving Mocha's tests, coverage, or CI config semver-major implementation requires increase of "major" version number; "breaking changes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants