Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of 'growl' notification #4866

Merged
merged 3 commits into from Apr 15, 2022
Merged

Drop support of 'growl' notification #4866

merged 3 commits into from Apr 15, 2022

Conversation

juergba
Copy link
Member

@juergba juergba commented Apr 9, 2022

Description

Growl is a retired project, see here.

We remove our --growl option and its corresponding notification feature:

  • we have announced this step in Aug/21 and we haven't received any negative user feedbacks.
  • announced migration tests with alternative notification systems as eg. node-notifier have never been undertaken.
  • this nice-to-have feature does not belong into Mocha's core. It's old fashioned, our growl code base is poorly maintained and most IDE offers better reporting options.

@juergba juergba self-assigned this Apr 9, 2022
@juergba juergba added usability semver-major refactor labels Apr 9, 2022
@juergba juergba added this to the v10.0.0 milestone Apr 9, 2022
@juergba juergba marked this pull request as ready for review Apr 10, 2022
@juergba juergba merged commit ac81cc5 into master Apr 15, 2022
22 checks passed
@juergba juergba deleted the juergba/growl branch Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor semver-major usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant