Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard Promise.allSettled instead polyfill #4905

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Use standard Promise.allSettled instead polyfill #4905

merged 1 commit into from
Aug 10, 2022

Conversation

outsideris
Copy link
Contributor

Description of the Change

We've introduced @ungap/promise-all-settled in #4476.
And Node.js support Promise.allSettled in Node 12.9.0.

So, we don't need polyfill anymore because we support Node 14+.

Why should this be in core?

We don't need polyfill anymore.

Benefits

dependency is reduced.

Possible Drawbacks

N/A

@outsideris
use standard Promise.allSettled instead polyfill
c557d79 
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris outsideris added the type: chore generally involving deps, tooling, configuration, etc. label Jul 31, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.326% when pulling c557d79 on use-builtin-allsettled into 84b2f84 on master.

@juergba
Copy link
Contributor

juergba commented Aug 9, 2022

@outsideris I guess this PR makes sense.
One of your links points to a korean page. I couldn't find any docs about Node supporting Promise.allSettled(). Can you help, please?

@outsideris
Copy link
Contributor Author

Oops! Sorry for korea link.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled

CleanShot 2022-08-10 at 03 10 05@2x

And you can see 12.9.0 release note.

juergba
juergba approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsideris thank you for your explanations and this PR.

@juergba juergba merged commit 77c18d2 into master Aug 10, 2022
@juergba juergba added this to the next milestone Aug 10, 2022
@juergba juergba added the type: cleanup a refactor label Aug 10, 2022
@Grizzelbee Grizzelbee mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
type: chore generally involving deps, tooling, configuration, etc. type: cleanup a refactor
Projects
None yet
Milestone
v10.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@outsideris @coveralls @juergba