Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

suite.skip() does not work like describe.skip() #762

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

When using the TDD style, calling suite.skip() does not appear to properly put the suite into a pending state.

Contributor

jugglinmike commented Mar 26, 2013

Nice work, @jaredwinick! It would be great to have closer parity between the runner interfaces.

One thing you can do to help get this merged: move your change into the lib/interfaces/tdd.js source file (mocha.js is a built file--you invoke make to generate it).

If you're busy, I'd be happy to open a new pull request with this change, but I thought you might want a chance to fix it.

Oh sure, I will move the change to tdd.js. Sorry, I didn't look into how Mocha was built before submitting the pull request, my fault there. I will try and get this done soon, but it might be a couple days. Thanks again for the pointers, it is much appreciated.

Contributor

jugglinmike commented May 30, 2013

@jaredwinick Any progress here? If you don't have the time, I'd be happy to make a new pull request with your changes applied to the source files.

yeah, go for it. slammed at work these days so i would be happy as long as
the fix gets into the code for others. thanks a lot.

On Thu, May 30, 2013 at 3:56 PM, jugglinmike notifications@github.comwrote:

@jaredwinick https://github.com/jaredwinick Any progress here? If you
don't have the time, I'd be happy to make a new pull request with your
changes applied to the source files.


Reply to this email directly or view it on GitHubhttps://github.com/visionmedia/mocha/pull/762#issuecomment-18711103
.

Jared Winick
Software Engineer
Koverse, Inc.
jaredwinick@koverse.com
720-961-3399

jugglinmike added a commit to jugglinmike/mocha that referenced this pull request May 30, 2013

Implement `suite.skip()`
Increase parity between the "TDD" and "BDD" interfaces by implementing
`suite.skip()`. (The implementation was originally authored by
@jaredwinick in GitHub pull request #762 but applied to the wrong file
and lacking a unit test.)
Contributor

jugglinmike commented May 30, 2013

Alright, thanks @jaredwinick! I've opened #884 with your changes re-applied to the correct files and a unit test to back them up. I've listed your GitHub handle in the commit message, as well.

@tj tj closed this May 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment