Cookie crash on DST changes #73

Closed
essen opened this Issue Mar 9, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@essen

essen commented Mar 9, 2012

Hey. There's a possibility of a crash happening in the cookie code when the time is set on a DST change: https://github.com/mochi/mochiweb/blob/master/src/mochiweb_cookies.erl#L124

It got reported initially in cowboy whose cookie support is a direct port of mochiweb's written by @bfrog - issue here with more details: extend/cowboy#157

I didn't test it specifically in mochiweb, so you might already have taken measures to prevent it in which case please disregard this report.

Pinging related people @ferd @klaar to notice them about me opening this issue here.

@emad

This comment has been minimized.

Show comment
Hide comment
@emad

emad Mar 9, 2012

Member

thanks for the report, I guess we never came across this issue at Mochi because we avoid DST.

Member

emad commented Mar 9, 2012

thanks for the report, I guess we never came across this issue at Mochi because we avoid DST.

@essen

This comment has been minimized.

Show comment
Hide comment
@essen

essen Mar 9, 2012

We have pushed a fix, which you can probably copy-paste for mochiweb: ninenines/cowboy@3376b72

If the comment isn't enough @klaar can explain it in greater details. Enjoy!

essen commented Mar 9, 2012

We have pushed a fix, which you can probably copy-paste for mochiweb: ninenines/cowboy@3376b72

If the comment isn't enough @klaar can explain it in greater details. Enjoy!

emad added a commit that referenced this issue Mar 9, 2012

@emad emad closed this Mar 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment