Exit with meaningful error messages instead of 'normal'. #74

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jdhood1

jdhood1 commented Apr 19, 2012

I'm not sure why you guys decided to exit with the atom 'normal' instead of the error that was returned from the call being made, but I'm having a tough time figuring out a socket error I'm getting from one of our clients without the information from gen_tcp:send(...). This change would really help that process. Thanks.

@etrepum

This comment has been minimized.

Show comment
Hide comment
@etrepum

etrepum Apr 19, 2012

Member

If you're handling billions of requests the TCP errors are guaranteed to happen often and not interesting. The error logging can take down your server actually. I won't accept this pull request but that shouldn't stop you from modifying your local copy as you see fit.

Member

etrepum commented Apr 19, 2012

If you're handling billions of requests the TCP errors are guaranteed to happen often and not interesting. The error logging can take down your server actually. I won't accept this pull request but that shouldn't stop you from modifying your local copy as you see fit.

@etrepum etrepum closed this Apr 19, 2012

@jdhood1

This comment has been minimized.

Show comment
Hide comment
@jdhood1

jdhood1 Apr 19, 2012

Understood. Thanks for the quick response.

-----Original Message-----
From: Bob Ippolito <reply
+i-4194589-9dcd4ee0f6568f56f99d5d54cda9f82175a07db8-439511@reply.github.com>

If you're handling billions of requests the TCP errors are guaranteed to happen often and not interesting. The error logging can take down your server actually. I won't accept this pull request but that shouldn't stop you from modifying your local copy as you see fit.

jdhood1 commented Apr 19, 2012

Understood. Thanks for the quick response.

-----Original Message-----
From: Bob Ippolito <reply
+i-4194589-9dcd4ee0f6568f56f99d5d54cda9f82175a07db8-439511@reply.github.com>

If you're handling billions of requests the TCP errors are guaranteed to happen often and not interesting. The error logging can take down your server actually. I won't accept this pull request but that shouldn't stop you from modifying your local copy as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment