Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix a case in handling range headers #85

Merged
merged 1 commit into from Oct 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

pmundkur commented Oct 8, 2012

The range-header handling does not implement the following:
http://tools.ietf.org/html/rfc2616#section-14.35.1

If the last-byte-pos value is absent, or if
the value is greater than or equal to the current
length of the entity-body, last-byte-pos is taken
to be equal to one less than the current length of
the entity-body in bytes.

Specifically, the 'greater than equal to' case.

@pmundkur pmundkur The range-header handling does not implement the following:
http://tools.ietf.org/html/rfc2616#section-14.35.1

  If the last-byte-pos value is absent, or if
  the value is greater than or equal to the current
  length of the entity-body, last-byte-pos is taken
  to be equal to one less than the current length of
  the entity-body in bytes.

Specifically, the 'greater than equal to' case.
fe5e0c5

End >= Size is a bit redundant here

Owner

pmundkur replied Oct 12, 2012

Good catch. I can send you another pull with that cleaned up, unless you want more changes.

This is fine as-is, just was making a note of it.

@etrepum etrepum added a commit that referenced this pull request Oct 12, 2012

@etrepum etrepum Merge pull request #85 from pmundkur/fix-ranges
Fix a case in handling range headers
e282266

@etrepum etrepum merged commit e282266 into mochi:master Oct 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment