Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skyscreamer / JSONassert dependency #738

Closed
ngeor opened this issue Feb 28, 2020 · 3 comments
Closed

Remove skyscreamer / JSONassert dependency #738

ngeor opened this issue Feb 28, 2020 · 3 comments
Assignees
Labels

Comments

@ngeor
Copy link

@ngeor ngeor commented Feb 28, 2020

Describe the feature request
Please remove the skyscreamer / JSONassert dependency because of the following reasons:

  • it seems to be outdated (no commit in 3 years)
  • as per its README file, it has a dependency on "com.vaadin.external.google:android-json", which brings its own org.json.* implementations. When used together in a project that uses the real org.json, it wrecks havoc with difficult to diagnose JAR hell kind of errors.

The solution you'd like
The problematic dependency should be removed.

Describe alternatives you've considered
The issue is already reported in the skyscreamer repository ( skyscreamer/JSONassert#99 ) but with no activity. From there however, on a completely unrelated repository, someone seems to be replacing skyscreamer with JsonUnit, maybe that is something to explore

@ngeor ngeor added the enhancement label Feb 28, 2020
@jamesdbloom jamesdbloom self-assigned this Mar 14, 2020
@jamesdbloom

This comment has been minimized.

Copy link
Collaborator

@jamesdbloom jamesdbloom commented Mar 14, 2020

I agree this is a good idea which I'll look into the major issue is maintaining backward compatibility with the MockServer API but I assume that should be possible.

@jamesdbloom

This comment has been minimized.

Copy link
Collaborator

@jamesdbloom jamesdbloom commented Mar 14, 2020

I've added this to Trello as new feature requests are now prioritised on Trello, so I'm closing issue in GitHub, only bugs or unaccepted feature requests will stay in GitHub, so that new feature backlog can be more effectively managed, see: https://trello.com/c/3w1aQnlA/98-replace-jsonassert

There is a link back to this issue so I'll close this issue but updated it once the Trello feature has been implemented. I would estimate it'll take a couple of months for this to be released unless someone provides a PR for it.

jamesdbloom added a commit that referenced this issue Mar 21, 2020
…and remove problematic transitive dependencies
@jamesdbloom

This comment has been minimized.

Copy link
Collaborator

@jamesdbloom jamesdbloom commented Mar 21, 2020

This change has now been committed and will shortly be in the SNAPSHOT release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.