New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MatrixRun, add `built_to` field to MatrixRun, add BuildFlowJob and BuildFlowRun. #16

Merged
merged 3 commits into from Jun 13, 2018

Conversation

Projects
None yet
3 participants
@davidtwco
Contributor

davidtwco commented Jun 13, 2018

Fixes #15 (though I did already close that).

Thanks for the awesome crate! - happy to make any requested changes to the PR to get it merged. Also able to split this up into a handful of smaller PRs if you prefer.

davidtwco added some commits Jun 13, 2018

@davidtwco

This comment has been minimized.

Contributor

davidtwco commented Jun 13, 2018

Just pushed another commit that's a bit more unrelated to the first two - it changes the data type of the duration and estimated_duration fields as some Jenkins instances I was testing with would return -1 in these fields on occasion - causing an error, applications can at least now check for a positive duration rather than have a function call fail completely. If this fix is undesirable, I'm happy to find another solution.

@coveralls

This comment has been minimized.

coveralls commented Jun 13, 2018

Coverage Status

Coverage decreased (-0.7%) to 69.096% when pulling 54ef681 on davidtwco:build-job-changes into 82a7c1c on mockersf:master.

@mockersf

This comment has been minimized.

Owner

mockersf commented Jun 13, 2018

Thank you !

@mockersf mockersf merged commit d300f82 into mockersf:master Jun 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.7%) to 69.096%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment