Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back getActualArguments() to NoMatchingExpectationException #1027

Merged
merged 1 commit into from Dec 4, 2019
Merged

Add back getActualArguments() to NoMatchingExpectationException #1027

merged 1 commit into from Dec 4, 2019

Conversation

@dciancu
Copy link
Contributor

@dciancu dciancu commented Nov 30, 2019

This has been removed in #1000 and is breaking backwords compatibility.

People are using this method to further customize the reason the test
failed based on the actual arguments like Laravel for example: https://github.com/laravel/framework/blob/fd17b307f546f449d24d4eed1725b4941a98b895/src/Illuminate/Foundation/Testing/PendingCommand.php#L139

Thanks,
Daniel

This has been removed in #1000 and is breaking backwords compatibility.

People are using this method to further customize the reason the test
failed based on the actual arguments like Laravel for example: https://github.com/laravel/framework/blob/fd17b307f546f449d24d4eed1725b4941a98b895/src/Illuminate/Foundation/Testing/PendingCommand.php#L139
@robertbasic robertbasic merged commit c216606 into mockery:master Dec 4, 2019
2 checks passed
Loading
@robertbasic
Copy link
Collaborator

@robertbasic robertbasic commented Dec 4, 2019

My bad, I apologize. Thank you!

Loading

@dciancu
Copy link
Contributor Author

@dciancu dciancu commented Dec 4, 2019

No problem, thanks for merging :)

Loading

@dciancu
Copy link
Contributor Author

@dciancu dciancu commented Dec 18, 2019

@robertbasic Any idea when you can do a point release please?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants