Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Support iterable and removed uneeded check #1075

Merged
merged 2 commits into from Jul 8, 2020
Merged

[1.3] Support iterable and removed uneeded check #1075

merged 2 commits into from Jul 8, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jul 7, 2020

TODO:

  • Implementation
  • Tests

Closes #869.

GrahamCampbell and others added 2 commits July 7, 2020 11:10
Co-Authored-By: Amélie-Dzovinar <dzov@users.noreply.github.com>
@GrahamCampbell GrahamCampbell marked this pull request as ready for review July 7, 2020 10:59
@@ -740,9 +743,7 @@ public function mockery_returnValueForMethod($name)
return null;

case 'object':
if (\PHP_VERSION_ID >= 70200) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is safe to do because in PHP less than 7.2, object will be parsed to \object by my new code.

case 'array': return [];

case 'array':
case 'iterable':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is safe because in PHP less than 7.1, iterable will be parsed to \iterable by my new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants