Fix Mockery::fetchMock() without initialized container #1113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Mockery::fetchMock()
first doesn't make much sense and likely indicates a logic error, but Mockery should nevertheless throwCall to a member function fetchMock() on null
errors.Maybe we should throw a
LogicException
instead when no container was initialized yet (just likeMockery::self()
)? If no container was initialized yet,Mockery::fetchMock()
will always returnnull
, just like if the mock in question simply doesn't exist (yet). Other opinions?