-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for PHP 8.1 #1130
Fixes for PHP 8.1 #1130
Conversation
Can you target the 1.3 branch please, so Laravel can get these fixes. |
@GrahamCampbell Sorry, I wasn't aware that Mockery doesn't follow semantic versioning. I've never changed target branch in PR, so I'm not sure how to do it correctly, will it work if I just change it via GitHub interface? I see Laravel 8 requires |
Mockey does follow semantic versioning, but the 1.4.x line has cranked the min PHP version. Laravel needs the 1.3.x line to continue to be maintained for the rest of 2021 (and I'm happy to do any and all additional work to make that happen). :) |
OK, I see. The strange version constraint made me think so. Wouldn't And please let me know what I need to do to change the target branch. I'm also happy to do this work, but in this case I'm not sure how. BTW, failing Laravel's tests are the reason I've opened this PR :) |
No. |
@GrahamCampbell Thanks for your anwsers :) I've changed the target to 1.3, but I can't run tests ( |
Looks like we need to move to GH actions. I'll create an issue and do it soon. |
While PHP 8.1 has not been released yet, it is common to allow such a build to fail. The tests currently fail due to PHP 8.1 incompatibilities in Mockery. A PR for (most of) these is already open in the Mockery repo: mockery/mockery#1130 Once Mockery has been made compatible with PHP 8.1, the `continue-on-error` setting should be revisited after verifying that all tests pass.
While PHP 8.1 has not been released yet, it is common to allow such a build to fail. The tests currently fail due to PHP 8.1 incompatibilities in Mockery. A PR for (most of) these is already open in the Mockery repo: mockery/mockery#1130 Once Mockery has been made compatible with PHP 8.1, the `continue-on-error` setting should be revisited after verifying that all tests pass.
Merged. I'm a bit short on time right now, summer holidays, kids etc, so I've not given it a proper good looking at, trusting @GrahamCampbell 👍 |
@davedevelopment Thank you!
|
That change to 1.4.x should probably also be backported to 1.3.x. |
@GrahamCampbell The commit I mentioned is the version for 1.4, which on your request I later backported to 1.3. It had conflicts in this method, so this version may come in handy when merging this PR to 1.4. |
Serializable
test on PHP <8.1