[1.3] Fix auto-generated return values with union types #1143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is now:
So,
int|false
will auto-return0
andFoo|false
will auto-returnfalse
. The old logic was very similar, but broken because it looked at the stringint|false
, decided it was not primitive, and then tried to mock it.Before fix:
After fix:
Blocks laravel/framework#38404. cc @davedevelopment, @driesvints.