Override default call count expectations via expects()

[ghostwriter]

By default expects() sets up an expectation that the method should be called once and once only.

http://docs.mockery.io/en/stable/reference/alternative_should_receive_syntax.html#expects
http://docs.mockery.io/en/stable/reference/expectations.html#declaring-call-count-expectations

If accepted, this example code will run as expected.

$this->mock->expects('foo')->atLeast()->once();

// and or

$this->mock->expects()->foo()->atMost()->once();

• Add failing test
• Implement the bug fix
• Resolves expects('foo')->atLeast()->once() errors on two calls #1138

[Bilge]

@davedevelopment How does this look to you?

[davedevelopment]

Merged, thank you, apologies for the tardiness

[Bilge]

@davedevelopment Could we get a tag for this?

[freiondrej-lmc]

@davedevelopment it would be amazing if you could tag this, we've just encountered this behavior in our test suite. It's great that it's been fixed already, but we don't want to require dev-master

[davedevelopment]

Sorry for the delay. I'll see if I can get around to tagging sometime soon.

[Bilge]

Bro, what? You just type git tag ver and git push --tag. You literally spent more time typing that comment than just pushing a tag.

[davedevelopment]

I usually spend a bit of time reviewing what has changed and updating the CHANGELOG etc. It doesn't take long, but I don't have that much time to contribute and I'd rather not rush.

Bilge has annoyed me enough times, he's rarely constructive so I've blocked him.