Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some stock bodies have peaks that are higher than the time warp limit #1413

Closed
maccollo opened this issue May 29, 2017 · 3 comments

Comments

@maccollo
Copy link

commented May 29, 2017

For example, Minmus highest points are around 5-6 km, but the timewarp limit is 3 km, making landing at these locations impossible with Principia.
Similar locations exist on Mun, Ike and Gilly.

@oititov

This comment has been minimized.

Copy link

commented May 29, 2017

I confirm. It's even worse in RSS, where the Moon's Lunar Seas have an altitude of 7,5 km with the default timewarp limit of 5 km. At least with RSS it can be "fixed" with Kopernicus configs.

@pleroy pleroy added the bug label Jun 2, 2017

@eggrobin

This comment has been minimized.

Copy link
Member

commented Jun 4, 2017

This seems complicated; it seems that KSP puts the inverse rotation limit way higher than the atmosphere or the highest peaks, which means we don't want to use that as our manageability threshold (we would like to manage vessels in LKO etc.).
We have to set the inverse rotation limit to something lower, because we do not currently support managing the vessel when KSP's frame is rotating.
We cannot easily get the altitude of the highest peak programmatically, so we cannot set an accurate lower threshold; we rely on the timewarp limit, which is inaccurate (or the atmosphere, which is generally much better).
For the moment, there is nothing we can do that wouldn't be equivalent to making Kopernicus configs setting the timewarp limit appropriately for every solar system out there; this can be done as a workaround if you need to land on mountains in the short term.

Eventually, we could support managing the vessel even when KSP is using a rotating frame, and that issue would disappear; this would also allow managing the vessel as soon as it leaves the ground even in an atmosphere, allowing use of our trajectory plots during ascent.

@pleroy

This comment has been minimized.

Copy link
Member

commented Aug 12, 2017

Also related to #848.

@eggrobin eggrobin closed this in 73eb3e9 Oct 13, 2017

eggrobin added a commit to eggrobin/RealSolarSystem that referenced this issue Oct 18, 2017
Revert 9c611dc
The timewarp altitude limit was raised in #112 to work around mockingbirdnest/Principia#1413. The latter issue was fixed with the release of Chasles, and as discussed in #111, raising the altitude limit hampered usability. Reverting the obsolete workaround.
eggrobin added a commit to eggrobin/RealSolarSystem that referenced this issue Oct 18, 2017
Revert 9c611dc
The timewarp altitude limit was raised in #112 to work around mockingbirdnest/Principia#1413. The latter issue was fixed with the release of Chasles, and, as discussed in #111, raising the altitude limit hampered usability. Reverting the obsolete workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.