This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
Progress on concise release notes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We need to get release date information from VCS. The date is associated with the tag. Otherwise we cannot built concise release notes. - More work is pending, specifically I need to write the integration with Git (the implementation currently contains big fat TODO).
- Needed for the work on VCS implementation and getting tag dates from Git - Also will be used in the formatters
For given set of versions, we're now getting the release date from Git
- reduced code duplication, driving consistency - stopped including 'UTC' in the release notes. I don't think it adds value but it is noisy (duplicated in every line of the release notes, see: https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made progress on issue #9
The concise report now contains release dates based on the date of creation of Git tag.