Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Javadoc of RETURNS_SMART_NULLS, default answer in Mockito 4.0.0? #2460

Closed
flyaway2112 opened this issue Oct 30, 2021 · 1 comment
Closed

Comments

@flyaway2112
Copy link
Contributor

@flyaway2112 flyaway2112 commented Oct 30, 2021

Javadoc for Mockito.RETURNS_SMART_NULLS in version 4.0.0 still says:

ReturnsSmartNulls will be probably the default return values strategy in Mockito 4.0.0

As Mockito 4.0.0 has been released this could now be clarified. I see #971 is still open, so it looks like the default answer has not been changed?

See also: #1743

@flyaway2112 flyaway2112 changed the title Clarify Javadoc of RETURNS_SMART_NULLS, default answer in Mockito 3.0.0? Clarify Javadoc of RETURNS_SMART_NULLS, default answer in Mockito 4.0.0? Oct 30, 2021
@TimvdLippe
Copy link
Contributor

@TimvdLippe TimvdLippe commented Oct 30, 2021

Hm. Yeah. In retrospect, I think it is better to remove this statement altogether. As far as I know, we are not planning on making this change anytime soon and therefore I also think it doesn't make sense to commit to a particular version.

Do you mind sending us a PR that removes the sentence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants