Remove ExpectedException from internal test suite

[TimvdLippe]

The rule is not ideal, as it will trigger even if the test fails for a completely different reason. Instead, we should use assertj with assertThatThrownBy to denote which specific line should trigger the exception.

[TimvdLippe]

#2511 contains an example replacement. The expectation is that we do the same for all the other test suites we have lying around.

[temp-droid]

Should we include the existing assertj assertThatThrownBy cases to make them consistent with the use of lambda instead of runnable?

[TimvdLippe]

@temp-droid I don't think we need a dedication cleanup for that, but if you are changing a test that has runnables, then yes let's convert them to lambdas instead. Do you want to take on this task? Thanks in advance!

[temp-droid]

@TimvdLippe Do you want to remove @Test(expected = […].class) oriented tests too?

EDIT: just realized in the same file I'm looking into (MockInjectionUsingConstructorTest), we also have the classic try or fail catch assert type we could change.

[TimvdLippe]

Yes to both of these, thanks!