-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mockito-errorprone seems not compatible with ErrorProne 2.11.0 #2554
Comments
This also fixes #2554, by using `.withNoParameters()` instead.
We are working on this in #2553, but we ran into google/error-prone#2926 So we have to wait for ErrorProne 2.11.1 to get it fixed. |
* Bump versions.errorprone from 2.10.0 to 2.11.0 Bumps `versions.errorprone` from 2.10.0 to 2.11.0. Updates `error_prone_core` from 2.10.0 to 2.11.0 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.10.0...v2.11.0) Updates `error_prone_test_helpers` from 2.10.0 to 2.11.0 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.10.0...v2.11.0) --- updated-dependencies: - dependency-name: com.google.errorprone:error_prone_core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.errorprone:error_prone_test_helpers dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix compilation for JDK 8 This also fixes #2554, by using `.withNoParameters()` instead. * Extract method for JDK 8 For some reason, Java 8 chooses the wrong subclass for this specific use case. All other assertions are fine and this doesn't happen on JDK 11. Therefore, let's extract it into a method to force the correct type. * Fixes #2554: Upgrade Error Prone 2.11 -> 2.12 See: - https://github.com/google/error-prone/releases/tag/v2.12.0 - google/error-prone@v2.11.0...v2.12.0 * Upgrade Error Prone 2.12.0 -> 2.12.1 See: - https://github.com/google/error-prone/releases/tag/v2.12.1 - google/error-prone@v2.12.0...v2.12.1 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tim van der Lippe <tvanderlippe@google.com>
@TimvdLippe the issue still can be reproduced with ErrorProne 2.12.1. ErrorProne: 2.12.1
PS: Sorry for opening a duplicate. |
This fix has not yet been released as part of Mockito 4.5.0. @raphw can you publish a release maybe? I think we can even make it a patch release (4.4.1), as I don't think we shipped any other features since 4.4.0. |
I pushed a release! |
When will this be published in Maven Central? |
We use mockito-errorprone of version 4.3.1 and it seems not compatible with ErrorProne of version 2.11.0.
Our compilation got broken when we updated ErrorProne to 2.11.0 with such error:
Take a look at the full error log
Versions:
The text was updated successfully, but these errors were encountered: